Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nix fixes and CTL 5.0 #9

Merged
merged 9 commits into from
Feb 28, 2023
Merged

Nix fixes and CTL 5.0 #9

merged 9 commits into from
Feb 28, 2023

Conversation

mikekeke
Copy link
Collaborator

@mikekeke mikekeke commented Feb 23, 2023

Closes #3

This PR updates CTL to 5.0 and fixes Nix app for CTL runtime to be able to configure it.

- improved: car run configurable CTL runtime of needed
- updated: CTL to 5.0
- added: test and check to make sure Plutip tests are runnable
- added: miniwiki on how to work with setup
case (unwrap userAction).action of
AddAmount amount -> undefined -- TODO create a transaction consuming useUTxO that
action2UTxO userAction useUTxO = undefined
-- case (unwrap userAction).action of
Copy link
Collaborator Author

@mikekeke mikekeke Feb 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented out this part to make build and Nix check pass.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The work on this would be on another pr, so, it's ok.

@@ -1,53 +1,54 @@
-- | This module is used to serve the E2E tests to the headless browser.
module Seath.Test.E2E.Serve where

import Contract.Prelude
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just commented out everything here for now to make build and check pass. Do we need it? Maybe delete for now.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are tests inherited from CTL, we don't need them but we definitively can reuse this and fill it with our own test, so, leaving them commented, for now, is the way to go I think.

@mikekeke mikekeke changed the title Nix fixes and ctl 5 0 Nix fixes and CTL 5.0 Feb 23, 2023
@@ -7,6 +7,7 @@
"test": "test"
},
"scripts": {
"blockfrost-test": "source ./test/blockfrost.env && spago run --main Scaffold.Test.Blockfrost",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we planning to use blockfrost as backend?

@@ -7,6 +7,7 @@
"test": "test"
},
"scripts": {
"blockfrost-test": "source ./test/blockfrost.env && spago run --main Scaffold.Test.Blockfrost",
"test": "spago run --main Test.Seath.Main",
"e2e-serve": "make e2e-serve",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we probably can delete all the e2e tests from ctl, at least this part won't work now that makefile is deleted.

@@ -1,53 +1,54 @@
-- | This module is used to serve the E2E tests to the headless browser.
module Seath.Test.E2E.Serve where

import Contract.Prelude
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are tests inherited from CTL, we don't need them but we definitively can reuse this and fill it with our own test, so, leaving them commented, for now, is the way to go I think.

case (unwrap userAction).action of
AddAmount amount -> undefined -- TODO create a transaction consuming useUTxO that
action2UTxO userAction useUTxO = undefined
-- case (unwrap userAction).action of
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The work on this would be on another pr, so, it's ok.

@mikekeke mikekeke merged commit 32af437 into development Feb 28, 2023
@Luis-omega Luis-omega mentioned this pull request Mar 2, 2023
1 task
@Luis-omega Luis-omega deleted the nix-fixes-and-ctl-5-0 branch March 2, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants