-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nix fixes and CTL 5.0 #9
Conversation
- improved: car run configurable CTL runtime of needed - updated: CTL to 5.0 - added: test and check to make sure Plutip tests are runnable - added: miniwiki on how to work with setup
case (unwrap userAction).action of | ||
AddAmount amount -> undefined -- TODO create a transaction consuming useUTxO that | ||
action2UTxO userAction useUTxO = undefined | ||
-- case (unwrap userAction).action of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commented out this part to make build and Nix check pass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The work on this would be on another pr, so, it's ok.
@@ -1,53 +1,54 @@ | |||
-- | This module is used to serve the E2E tests to the headless browser. | |||
module Seath.Test.E2E.Serve where | |||
|
|||
import Contract.Prelude |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just commented out everything here for now to make build and check pass. Do we need it? Maybe delete for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those are tests inherited from CTL, we don't need them but we definitively can reuse this and fill it with our own test, so, leaving them commented, for now, is the way to go I think.
off-chain/package.json
Outdated
@@ -7,6 +7,7 @@ | |||
"test": "test" | |||
}, | |||
"scripts": { | |||
"blockfrost-test": "source ./test/blockfrost.env && spago run --main Scaffold.Test.Blockfrost", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we planning to use blockfrost as backend?
off-chain/package.json
Outdated
@@ -7,6 +7,7 @@ | |||
"test": "test" | |||
}, | |||
"scripts": { | |||
"blockfrost-test": "source ./test/blockfrost.env && spago run --main Scaffold.Test.Blockfrost", | |||
"test": "spago run --main Test.Seath.Main", | |||
"e2e-serve": "make e2e-serve", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we probably can delete all the e2e tests from ctl, at least this part won't work now that makefile
is deleted.
@@ -1,53 +1,54 @@ | |||
-- | This module is used to serve the E2E tests to the headless browser. | |||
module Seath.Test.E2E.Serve where | |||
|
|||
import Contract.Prelude |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those are tests inherited from CTL, we don't need them but we definitively can reuse this and fill it with our own test, so, leaving them commented, for now, is the way to go I think.
case (unwrap userAction).action of | ||
AddAmount amount -> undefined -- TODO create a transaction consuming useUTxO that | ||
action2UTxO userAction useUTxO = undefined | ||
-- case (unwrap userAction).action of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The work on this would be on another pr, so, it's ok.
Closes #3
This PR updates CTL to 5.0 and fixes Nix app for CTL runtime to be able to configure it.