Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'show_sun' option not documented in README #160

Closed
tkw1536 opened this issue Apr 6, 2024 · 0 comments · Fixed by #176
Closed

'show_sun' option not documented in README #160

tkw1536 opened this issue Apr 6, 2024 · 0 comments · Fixed by #176
Assignees
@mlamberts78
Labels
bug Something isn't working

Comments

@tkw1536
Copy link

tkw1536 commented Apr 6, 2024

Describe the bug
I was looking for an option to hide the sunrise / sunset from the main section.
After looking at the source code I found out it exists and is called 'show_sun'.
However it seems to be undocumented, as I cannot find it in the README.

To Reproduce
N/A

Expected behavior

I expected to have the option to have been documented, with no need to look through source code.

Screenshots

N/A

Desktop (please complete the following information):

  • WEATHER-CHART-CARD VERSION: v2.4.5
  • HOME ASSISTANT VERSION AND INSTALLATION TYPE: Home Assistant Operating System 2024.4.1
  • OS: Mac
  • Browser: Chrome
  • Version: 123

Additional context
N/A
@tkw1536 tkw1536 added the bug Something isn't working label Apr 6, 2024
@mlamberts78 mlamberts78 self-assigned this Apr 6, 2024
@mlamberts78 mlamberts78 mentioned this issue May 10, 2024
Merged
mlamberts78 added a commit that referenced this issue May 10, 2024
@mlamberts78
Merge pull request #176 from mlamberts78/develop
e88206b 
### **🚀 Features**
- Added Korean translation. Thanks @miumida

### **🛠 Under the hood**
- Fixed missing sun setting in readme (Closes #160)
- Updated some Portuguese translation. Thanks @ViPeR5000
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mlamberts78 mlamberts78

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Multiple fixes mlamberts78/weather-chart-card
2 participants
@tkw1536 @mlamberts78