Skip to content

Commit 174d1c1

Browse files
committed
fix(icon): FileInput default icon changed from file_download to file_upload
Closes #1325
1 parent b5f93ae commit 174d1c1

8 files changed

Lines changed: 20 additions & 16 deletions

File tree

examples/create-react-app-typescript/src/components/Layout/Layout.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import {
88
ConfigurableIcons,
99
Configuration,
1010
ErrorOutlineSVGIcon,
11-
FileDownloadSVGIcon,
11+
FileUploadSVGIcon,
1212
KeyboardArrowDownSVGIcon,
1313
KeyboardArrowLeftSVGIcon,
1414
KeyboardArrowRightSVGIcon,
@@ -25,7 +25,7 @@ import navItems from "./navItems";
2525
const icons: ConfigurableIcons = {
2626
back: <KeyboardArrowLeftSVGIcon />,
2727
checkbox: <CheckBoxSVGIcon />,
28-
download: <FileDownloadSVGIcon />,
28+
download: <FileUploadSVGIcon />,
2929
dropdown: <ArrowDropDownSVGIcon />,
3030
error: <ErrorOutlineSVGIcon />,
3131
expander: <KeyboardArrowDownSVGIcon />,

examples/create-react-app/src/components/Layout/Layout.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import {
66
CheckSVGIcon,
77
Configuration,
88
ErrorOutlineSVGIcon,
9-
FileDownloadSVGIcon,
9+
FileUploadSVGIcon,
1010
KeyboardArrowDownSVGIcon,
1111
KeyboardArrowLeftSVGIcon,
1212
KeyboardArrowRightSVGIcon,
@@ -23,7 +23,7 @@ import navItems from './navItems';
2323
const icons = {
2424
back: <KeyboardArrowLeftSVGIcon />,
2525
checkbox: <CheckBoxSVGIcon />,
26-
download: <FileDownloadSVGIcon />,
26+
download: <FileUploadSVGIcon />,
2727
dropdown: <ArrowDropDownSVGIcon />,
2828
error: <ErrorOutlineSVGIcon />,
2929
expander: <KeyboardArrowDownSVGIcon />,

examples/gatsby-typescript/src/components/Layout/Layout.jsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import {
55
CheckSVGIcon,
66
Configuration,
77
ErrorOutlineSVGIcon,
8-
FileDownloadSVGIcon,
8+
FileUploadSVGIcon,
99
KeyboardArrowDownSVGIcon,
1010
KeyboardArrowLeftSVGIcon,
1111
KeyboardArrowRightSVGIcon,
@@ -23,7 +23,7 @@ import navItems from "./navItems"
2323
const icons = {
2424
back: <KeyboardArrowLeftSVGIcon />,
2525
checkbox: <CheckBoxSVGIcon />,
26-
download: <FileDownloadSVGIcon />,
26+
download: <FileUploadSVGIcon />,
2727
dropdown: <ArrowDropDownSVGIcon />,
2828
error: <ErrorOutlineSVGIcon />,
2929
expander: <KeyboardArrowDownSVGIcon />,

examples/gatsby/src/components/Layout/Layout.jsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import {
55
CheckSVGIcon,
66
Configuration,
77
ErrorOutlineSVGIcon,
8-
FileDownloadSVGIcon,
8+
FileUploadSVGIcon,
99
KeyboardArrowDownSVGIcon,
1010
KeyboardArrowLeftSVGIcon,
1111
KeyboardArrowRightSVGIcon,
@@ -23,7 +23,7 @@ import navItems from "./navItems"
2323
const icons = {
2424
back: <KeyboardArrowLeftSVGIcon />,
2525
checkbox: <CheckBoxSVGIcon />,
26-
download: <FileDownloadSVGIcon />,
26+
download: <FileUploadSVGIcon />,
2727
dropdown: <ArrowDropDownSVGIcon />,
2828
error: <ErrorOutlineSVGIcon />,
2929
expander: <KeyboardArrowDownSVGIcon />,

examples/nextjs-typescript/src/components/Layout/Layout.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import {
88
ConfigurableIcons,
99
Configuration,
1010
ErrorOutlineSVGIcon,
11-
FileDownloadSVGIcon,
11+
FileUploadSVGIcon,
1212
KeyboardArrowDownSVGIcon,
1313
KeyboardArrowLeftSVGIcon,
1414
KeyboardArrowRightSVGIcon,
@@ -26,7 +26,7 @@ import navItems from "./navItems";
2626
const icons: ConfigurableIcons = {
2727
back: <KeyboardArrowLeftSVGIcon />,
2828
checkbox: <CheckBoxSVGIcon />,
29-
download: <FileDownloadSVGIcon />,
29+
download: <FileUploadSVGIcon />,
3030
dropdown: <ArrowDropDownSVGIcon />,
3131
error: <ErrorOutlineSVGIcon />,
3232
expander: <KeyboardArrowDownSVGIcon />,

examples/nextjs/src/components/Layout/Layout.jsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import {
66
CheckSVGIcon,
77
Configuration,
88
ErrorOutlineSVGIcon,
9-
FileDownloadSVGIcon,
9+
FileUploadSVGIcon,
1010
KeyboardArrowDownSVGIcon,
1111
KeyboardArrowLeftSVGIcon,
1212
KeyboardArrowRightSVGIcon,
@@ -24,7 +24,7 @@ import navItems from './navItems';
2424
const icons = {
2525
back: <KeyboardArrowLeftSVGIcon />,
2626
checkbox: <CheckBoxSVGIcon />,
27-
download: <FileDownloadSVGIcon />,
27+
download: <FileUploadSVGIcon />,
2828
dropdown: <ArrowDropDownSVGIcon />,
2929
error: <ErrorOutlineSVGIcon />,
3030
expander: <KeyboardArrowDownSVGIcon />,

packages/documentation/src/components/Layout/Layout.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import {
1212
CheckBoxSVGIcon,
1313
CheckSVGIcon,
1414
ErrorOutlineSVGIcon,
15-
FileDownloadSVGIcon,
15+
FileUploadSVGIcon,
1616
KeyboardArrowDownSVGIcon,
1717
KeyboardArrowLeftSVGIcon,
1818
KeyboardArrowRightSVGIcon,
@@ -50,7 +50,7 @@ const icons: ConfiguredIcons = {
5050
back: <KeyboardArrowLeftSVGIcon />,
5151
checkbox: <CheckBoxSVGIcon />,
5252
dropdown: <ArrowDropDownSVGIcon />,
53-
download: <FileDownloadSVGIcon />,
53+
download: <FileUploadSVGIcon />,
5454
expander: <KeyboardArrowDownSVGIcon />,
5555
error: <ErrorOutlineSVGIcon />,
5656
forward: <KeyboardArrowRightSVGIcon />,

packages/icon/src/IconProvider.tsx

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,11 @@ export interface ConfigurableIcons {
2626
dropdown?: ReactNode;
2727

2828
/**
29-
* The general icon to use for downloading content.
29+
* The general icon to use for the `FileInput` component (normally file
30+
* uploads).
31+
*
32+
* @remarks \@since 4.0.3 Changed the default icon to be `file_upload` and
33+
* this will be renamed to `upload` in the next major release.
3034
*/
3135
download?: ReactNode;
3236

@@ -89,7 +93,7 @@ export type ConfiguredIcons = Required<ConfigurableIcons>;
8993
const DEFAULT_ICONS: ConfiguredIcons = {
9094
back: <FontIcon>keyboard_arrow_left</FontIcon>,
9195
checkbox: <FontIcon>check_box</FontIcon>,
92-
download: <FontIcon>file_download</FontIcon>,
96+
download: <FontIcon>file_upload</FontIcon>,
9397
dropdown: <FontIcon>arrow_drop_down</FontIcon>,
9498
error: <FontIcon>error_outline</FontIcon>,
9599
expander: <FontIcon>keyboard_arrow_down</FontIcon>,

0 commit comments

Comments
 (0)