fix(icon): FileInput default icon changed from file_download to `fi…

…le_upload` Closes #1325
mlaursen · Dec 31, 2021 · 174d1c1 · 174d1c1
1 parent b5f93ae
commit 174d1c1
Show file tree

Hide file tree

Showing 8 changed files with 20 additions and 16 deletions.
diff --git a/examples/create-react-app-typescript/src/components/Layout/Layout.tsx b/examples/create-react-app-typescript/src/components/Layout/Layout.tsx
@@ -8,7 +8,7 @@ import {
   ConfigurableIcons,
   Configuration,
   ErrorOutlineSVGIcon,
-  FileDownloadSVGIcon,
+  FileUploadSVGIcon,
   KeyboardArrowDownSVGIcon,
   KeyboardArrowLeftSVGIcon,
   KeyboardArrowRightSVGIcon,
@@ -25,7 +25,7 @@ import navItems from "./navItems";
 const icons: ConfigurableIcons = {
   back: <KeyboardArrowLeftSVGIcon />,
   checkbox: <CheckBoxSVGIcon />,
-  download: <FileDownloadSVGIcon />,
+  download: <FileUploadSVGIcon />,
   dropdown: <ArrowDropDownSVGIcon />,
   error: <ErrorOutlineSVGIcon />,
   expander: <KeyboardArrowDownSVGIcon />,

diff --git a/examples/create-react-app/src/components/Layout/Layout.js b/examples/create-react-app/src/components/Layout/Layout.js
@@ -6,7 +6,7 @@ import {
   CheckSVGIcon,
   Configuration,
   ErrorOutlineSVGIcon,
-  FileDownloadSVGIcon,
+  FileUploadSVGIcon,
   KeyboardArrowDownSVGIcon,
   KeyboardArrowLeftSVGIcon,
   KeyboardArrowRightSVGIcon,
@@ -23,7 +23,7 @@ import navItems from './navItems';
 const icons = {
   back: <KeyboardArrowLeftSVGIcon />,
   checkbox: <CheckBoxSVGIcon />,
-  download: <FileDownloadSVGIcon />,
+  download: <FileUploadSVGIcon />,
   dropdown: <ArrowDropDownSVGIcon />,
   error: <ErrorOutlineSVGIcon />,
   expander: <KeyboardArrowDownSVGIcon />,

diff --git a/examples/gatsby-typescript/src/components/Layout/Layout.jsx b/examples/gatsby-typescript/src/components/Layout/Layout.jsx
@@ -5,7 +5,7 @@ import {
   CheckSVGIcon,
   Configuration,
   ErrorOutlineSVGIcon,
-  FileDownloadSVGIcon,
+  FileUploadSVGIcon,
   KeyboardArrowDownSVGIcon,
   KeyboardArrowLeftSVGIcon,
   KeyboardArrowRightSVGIcon,
@@ -23,7 +23,7 @@ import navItems from "./navItems"
 const icons = {
   back: <KeyboardArrowLeftSVGIcon />,
   checkbox: <CheckBoxSVGIcon />,
-  download: <FileDownloadSVGIcon />,
+  download: <FileUploadSVGIcon />,
   dropdown: <ArrowDropDownSVGIcon />,
   error: <ErrorOutlineSVGIcon />,
   expander: <KeyboardArrowDownSVGIcon />,

diff --git a/examples/gatsby/src/components/Layout/Layout.jsx b/examples/gatsby/src/components/Layout/Layout.jsx
@@ -5,7 +5,7 @@ import {
   CheckSVGIcon,
   Configuration,
   ErrorOutlineSVGIcon,
-  FileDownloadSVGIcon,
+  FileUploadSVGIcon,
   KeyboardArrowDownSVGIcon,
   KeyboardArrowLeftSVGIcon,
   KeyboardArrowRightSVGIcon,
@@ -23,7 +23,7 @@ import navItems from "./navItems"
 const icons = {
   back: <KeyboardArrowLeftSVGIcon />,
   checkbox: <CheckBoxSVGIcon />,
-  download: <FileDownloadSVGIcon />,
+  download: <FileUploadSVGIcon />,
   dropdown: <ArrowDropDownSVGIcon />,
   error: <ErrorOutlineSVGIcon />,
   expander: <KeyboardArrowDownSVGIcon />,

diff --git a/examples/nextjs-typescript/src/components/Layout/Layout.tsx b/examples/nextjs-typescript/src/components/Layout/Layout.tsx
@@ -8,7 +8,7 @@ import {
   ConfigurableIcons,
   Configuration,
   ErrorOutlineSVGIcon,
-  FileDownloadSVGIcon,
+  FileUploadSVGIcon,
   KeyboardArrowDownSVGIcon,
   KeyboardArrowLeftSVGIcon,
   KeyboardArrowRightSVGIcon,
@@ -26,7 +26,7 @@ import navItems from "./navItems";
 const icons: ConfigurableIcons = {
   back: <KeyboardArrowLeftSVGIcon />,
   checkbox: <CheckBoxSVGIcon />,
-  download: <FileDownloadSVGIcon />,
+  download: <FileUploadSVGIcon />,
   dropdown: <ArrowDropDownSVGIcon />,
   error: <ErrorOutlineSVGIcon />,
   expander: <KeyboardArrowDownSVGIcon />,

diff --git a/examples/nextjs/src/components/Layout/Layout.jsx b/examples/nextjs/src/components/Layout/Layout.jsx
@@ -6,7 +6,7 @@ import {
   CheckSVGIcon,
   Configuration,
   ErrorOutlineSVGIcon,
-  FileDownloadSVGIcon,
+  FileUploadSVGIcon,
   KeyboardArrowDownSVGIcon,
   KeyboardArrowLeftSVGIcon,
   KeyboardArrowRightSVGIcon,
@@ -24,7 +24,7 @@ import navItems from './navItems';
 const icons = {
   back: <KeyboardArrowLeftSVGIcon />,
   checkbox: <CheckBoxSVGIcon />,
-  download: <FileDownloadSVGIcon />,
+  download: <FileUploadSVGIcon />,
   dropdown: <ArrowDropDownSVGIcon />,
   error: <ErrorOutlineSVGIcon />,
   expander: <KeyboardArrowDownSVGIcon />,

diff --git a/packages/documentation/src/components/Layout/Layout.tsx b/packages/documentation/src/components/Layout/Layout.tsx
@@ -12,7 +12,7 @@ import {
   CheckBoxSVGIcon,
   CheckSVGIcon,
   ErrorOutlineSVGIcon,
-  FileDownloadSVGIcon,
+  FileUploadSVGIcon,
   KeyboardArrowDownSVGIcon,
   KeyboardArrowLeftSVGIcon,
   KeyboardArrowRightSVGIcon,
@@ -50,7 +50,7 @@ const icons: ConfiguredIcons = {
   back: <KeyboardArrowLeftSVGIcon />,
   checkbox: <CheckBoxSVGIcon />,
   dropdown: <ArrowDropDownSVGIcon />,
-  download: <FileDownloadSVGIcon />,
+  download: <FileUploadSVGIcon />,
   expander: <KeyboardArrowDownSVGIcon />,
   error: <ErrorOutlineSVGIcon />,
   forward: <KeyboardArrowRightSVGIcon />,

diff --git a/packages/icon/src/IconProvider.tsx b/packages/icon/src/IconProvider.tsx
@@ -26,7 +26,11 @@ export interface ConfigurableIcons {
   dropdown?: ReactNode;
 
   /**
-   * The general icon to use for downloading content.
+   * The general icon to use for the `FileInput` component (normally file
+   * uploads).
+   *
+   * @remarks \@since 4.0.3 Changed the default icon to be `file_upload` and
+   * this will be renamed to `upload` in the next major release.
    */
   download?: ReactNode;
 
@@ -89,7 +93,7 @@ export type ConfiguredIcons = Required<ConfigurableIcons>;
 const DEFAULT_ICONS: ConfiguredIcons = {
   back: <FontIcon>keyboard_arrow_left</FontIcon>,
   checkbox: <FontIcon>check_box</FontIcon>,
-  download: <FontIcon>file_download</FontIcon>,
+  download: <FontIcon>file_upload</FontIcon>,
   dropdown: <FontIcon>arrow_drop_down</FontIcon>,
   error: <FontIcon>error_outline</FontIcon>,
   expander: <FontIcon>keyboard_arrow_down</FontIcon>,