Skip to content

Commit

Permalink
fix(form): Prevent scrolling while dragging Slider on mobile
Browse files Browse the repository at this point in the history
  • Loading branch information
mlaursen committed Nov 29, 2021
1 parent 5e482bb commit 7eb6740
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions packages/form/src/slider/useSliderControls.ts
Original file line number Diff line number Diff line change
Expand Up @@ -170,10 +170,9 @@ export function useSliderControls({
return;
}

// prevent text from being highlighted while dragging the slider
// can't do it on touch events due to being passive events in later
// versions of React
if (!isTouchEvent(event)) {
// prevent text from being highlighted on desktop or the page from
// scrolling on mobile while dragging
if (!isTouchEvent(event) || event.type === "touchmove") {
event.preventDefault();
}
event.stopPropagation();
Expand Down Expand Up @@ -273,7 +272,7 @@ export function useSliderControls({
window.addEventListener("mousemove", drag);
window.addEventListener("mouseup", stop);
} else {
window.addEventListener("touchmove", drag);
window.addEventListener("touchmove", drag, { passive: false });
window.addEventListener("touchend", stop);
}

Expand Down

0 comments on commit 7eb6740

Please sign in to comment.