Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Look into refactoring or rewriting the accessibility hooks/utils for keyboard movement in widgets #1150

Open
mlaursen opened this issue May 13, 2021 · 0 comments
Open

Look into refactoring or rewriting the accessibility hooks/utils for keyboard movement in widgets #1150

mlaursen opened this issue May 13, 2021 · 0 comments
Labels
autocomplete menu Planning react-md Versions select tree utils wia-aria
Milestone
v6.0.0

Comments

@mlaursen
Copy link
Owner

The useKeyboardMovement, useActiveDescendantMovement, and useFocusMovement were an attempt at implementing some required accessibility helpers for different widgets. Since I wanted most of the movement utils to support typeahead movement as well, lots of components have a really weird and annoying api of stuff like getItemLabel and getItemValue. This kind of ruins the Menu component (and components that use the Menu) so it would be great to find a different way to implement this keyboard movement.

There's also some changes related to useFocusOnMount, usePreviousFocus, and useTabFocusWrap that could be combined and simplified to make updating other components easier and have a nicer API.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
autocomplete menu Planning react-md Versions select tree utils wia-aria
Projects
None yet
Milestone
v6.0.0
Development

No branches or pull requests
1 participant
@mlaursen