Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SelectFieldColumn needs to be Rewritten more like the EditDialogColumn #170

Closed
mlaursen opened this issue Dec 7, 2016 · 0 comments
Closed

SelectFieldColumn needs to be Rewritten more like the EditDialogColumn #170

mlaursen opened this issue Dec 7, 2016 · 0 comments
Labels
bug enhancement
Milestone
v1.0.0 Release

Comments

@mlaursen
Copy link
Owner

mlaursen commented Dec 7, 2016

The SelectFieldColumn doesn't really position itself correctly and if it is on the last row of the table, it jumps around which is distracting.
@mlaursen mlaursen added this to the v1.0.0 Release milestone Dec 7, 2016
mlaursen added a commit that referenced this issue Dec 12, 2016
@mlaursen
Fixed SelectFieldColumn and EditDialogColumn #170
32d95a8 
The SelectFieldColumn was rewritten so that is positions itself
absolutely a bit more accurately so that it can correctly overflow in
data tables. Also updated the SelectFieldColumn and EditDialogColumn so
that when they are open, they will reposition themselves if the user
scrolls the table left or right.

To get a better rendering experience, I had to remove the `position:
relative` from the `.md-table-column`, so tooltips no longer work. I
will need to fix that before release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug enhancement
Projects
None yet
Milestone
v1.0.0 Release
Development

No branches or pull requests
1 participant
@mlaursen