Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PropTypes.object to support forwardRef #809

Merged
merged 1 commit into from Oct 16, 2018
Merged

Add PropTypes.object to support forwardRef #809

merged 1 commit into from Oct 16, 2018

Conversation

luisrudge
Copy link
Contributor

I followed instructions for the PR, but couldn't run the docgen command:

image

fix #807
fix #808

@mlaursen mlaursen added this to the v1.7.2 milestone Oct 16, 2018
@mlaursen
Copy link
Owner

Hmm. I forgot what causes that. Have you run yarn build from the root directory before running docgen in the docs directory? However, this looks good to me; thanks!

@mlaursen mlaursen merged commit 5dd2474 into mlaursen:release/1.7.x Oct 16, 2018
@luisrudge
Copy link
Contributor Author

I didn’t. Thanks for merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug enhancement
Projects
None yet
Milestone
v1.7.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@luisrudge @mlaursen