fix(table): table border color uses hex values to fix chrome colSpan rendering issue
#982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rendering issue The table borders no longer use the `rmd-divider` mixin and colors due to a weird rendering issue with `colSpan` on tables. The workaround for this issue is to use a non-rgba value so the table now has new hex values for this: - `rmd-table-light-border-color: #e0e0e0` - `rmd-table-dark-border-color: #2f2f2f` - `rmd-table-border-color: if($rmd-light-theme, $rmd-table-light-border-color, $rmd-table-dark-border-color)` This also added a new `--rmd-table-border-color` CSS variable to configure this and should automatically update if you use the `rmd-theme-light/rmd-theme-dark` mixins.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The table borders no longer use the
rmd-dividermixin and colors due to a weird rendering issue withcolSpanon tables. The workaround for this issue is to use a non-rgba value so the table now has new hex values for this:$rmd-table-light-border-color: #e0e0e0$rmd-table-dark-border-color: #2f2f2f$rmd-table-border-color: if($rmd-light-theme, $rmd-table-light-border-color, $rmd-table-dark-border-color)This also added a new
--rmd-table-border-colorCSS variable to configure this and should automatically update if you use thermd-theme-light/rmd-theme-darkmixins.Screenshot Comparisons
Light Theme
Dark Theme
Reproducable Example
https://codesandbox.io/s/recursing-buck-otwdt