Add support for Google Pixel OpenCL #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this PR! This is amazing to see the OpenCL issue on Pixel gets fixed ❤️ BTW, do you want to instead submit PR to the mainline instead https://github.com/apache/tvm? We periodically sync with it and generally accept PRs there |
|
@alex4o Thanks for contribution! For another thing, could you please also fix the C++ format issue here https://ci.mlc.ai/blue/organizations/jenkins/mlc/detail/PR-282/1/pipeline? |
|
@junrushao I will make the PR against upstream later today, I just thought you might be more responsive and it will get merged faster. @MasterJH5574 thanks for the tip, I will run clang-format in it. |
|
@alex4o Thanks! We can merge this one first for sure once the formatting is addressed. |
alex4o
force-pushed
the
mlc
branch
4 times, most recently
from
44abc7d
to
4834f53
Compare
MasterJH5574
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google Pixel phones load the OpenCL symbols in a bit of a roundabout way.
This is the way google does it in TensorFlow-lite.
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/lite/delegates/gpu/cl/opencl_wrapper.cc#L75