[Relax][Pass] Split CallTIR By Pattern #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinhongyii
force-pushed
the
migrate-split-cutlass
branch
from
05b380b
to
3bd6c45
Compare
|
The pass depends on op legalizer |
jinhongyii
changed the title
jinhongyii
force-pushed
the
migrate-split-cutlass
branch
from
1fc57ba
to
3537fff
Compare
jinhongyii
force-pushed
the
migrate-split-cutlass
branch
from
5841381
to
9040c89
Compare
|
@spectrometerHBH @tqchen The split calltir pass and cutlass support is finished except pattern matching for convolution. It would be great if you can review it. Please ignore the op legalizer cherry-picked from Ruihang's branch. I will rebase it after legalizer is merged. |
tqchen
reviewed
Jan 15, 2023
| A_tvm = tvm.nd.array(A, dev) | ||
| B_tvm = tvm.nd.array(B, dev) | ||
| executable = tvm.runtime.load_module(filename) | ||
| result = f_run(executable, dev, A_tvm, B_tvm) |
There was a problem hiding this comment.
use before /expected tests ideally instead of execution test. exection test should go to a separate place under test_integration_trasnform_cutlass_codegen.py
There was a problem hiding this comment.
I can't think of a way to add before/expected tests because after applying the pass there will be extern funcs, and extern funcs cannot be parsed
tqchen
reviewed
Jan 15, 2023
tqchen
reviewed
Jan 15, 2023
jinhongyii
force-pushed
the
migrate-split-cutlass
branch
from
bc66e21
to
eefd6d2
Compare
|
@tqchen @spectrometerHBH The new version of tir matching and library codegen has been done. |
| TVM_DEFINE_OBJECT_REF_METHODS(MatchResult, ObjectRef, MatchResultNode) | ||
| }; | ||
|
|
||
| using FCodegen = runtime::TypedPackedFunc<Array<ObjectRef>(Array<MatchResult> match_results)>; |
There was a problem hiding this comment.
Codegen signature in principle is not part of tir pattern. Try to define it in other places.
spectrometerHBH
approved these changes
Jan 27, 2023
MasterJH5574
pushed a commit
that referenced
this pull request
Jan 28, 2023
This PR implements the library dispatcher for Relax, which currently uses CUTLASS as one library. It introduces the TIR-level pattern registration and matching algorithm. It introduces a Relax pass to split out subgraphs that match the patterns of backends.
MasterJH5574
pushed a commit
that referenced
this pull request
Jan 31, 2023
This PR implements the library dispatcher for Relax, which currently uses CUTLASS as one library. It introduces the TIR-level pattern registration and matching algorithm. It introduces a Relax pass to split out subgraphs that match the patterns of backends.
MasterJH5574
pushed a commit
that referenced
this pull request
Feb 8, 2023
This PR implements the library dispatcher for Relax, which currently uses CUTLASS as one library. It introduces the TIR-level pattern registration and matching algorithm. It introduces a Relax pass to split out subgraphs that match the patterns of backends.
MasterJH5574
pushed a commit
that referenced
this pull request
Feb 12, 2023
This PR implements the library dispatcher for Relax, which currently uses CUTLASS as one library. It introduces the TIR-level pattern registration and matching algorithm. It introduces a Relax pass to split out subgraphs that match the patterns of backends.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP