Support Delete All Data Interface #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Mostly LGTM, thank you!
Let's move these functions to a separate file, say src/cache_utils.py so that chat_module.ts is not too crowded. We just need to change index.ts accordingly.
Besides, I think we can combine deleteNDArrayInCache() and deleteTokenizerInCache() into a single function, since both reside in webllm/model.
|
Thanks! I just moved the functions to cache_util.ts and change corresponding index.ts and tested it. |
CharlieFRuan
approved these changes
Feb 27, 2024
|
Thank you! |
This was referenced Feb 27, 2024
CharlieFRuan
added a commit
that referenced
this pull request
Mar 2, 2024
The new version include 2 changes: - Include cache deletion API via #314 - Fix model download/caching issue on TVMjs side via apache/tvm#16650
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support async delete functions for the users