Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update carbon intensity data #350

Merged
merged 24 commits into from
May 25, 2023
Merged

Update carbon intensity data #350

merged 24 commits into from
May 25, 2023

Conversation

benoit-cty
Copy link
Contributor

@benoit-cty benoit-cty commented Nov 29, 2022 •
edited
Loading

Update carbon intensity data for cloud providers.
Remove AWS and Azure as they do not provide data.

@benoit-cty benoit-cty mentioned this pull request Nov 29, 2022
Closed
@benoit-cty benoit-cty linked an issue Nov 29, 2022 that may be closed by this pull request
Impact Values not Updated for Google cloud #339
Closed
@benoit-cty benoit-cty changed the title Update data Update carbon intensity data May 17, 2023
@benoit-cty benoit-cty marked this pull request as ready for review May 21, 2023 14:20
@benoit-cty benoit-cty requested a review from inimaz May 21, 2023 14:20
inimaz
inimaz requested changes May 21, 2023
View reviewed changes
Copy link
Contributor

@inimaz inimaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool, this will hopefully fix all the intermittent failing tests that we've been having lately in the pipeline. I added 2 small comments if you can check them?

codecarbon/core/emissions.py Show resolved Hide resolved
docs/_sources/faq.rst.txt Outdated Show resolved Hide resolved
@inimaz inimaz merged commit 39d81b4 into master May 25, 2023
5 checks passed
@benoit-cty benoit-cty deleted the UpdateData branch May 25, 2023 09:23
@wielrenner
Copy link

"Remove AWS and Azure as they do not provide data."
Any ideas when this can be added back again? Specifically interested in Azure.

@benoit-cty
Copy link
Contributor Author

Hello, if you know a place where we could find the emissions we will be happy to add them as we did not find them.
The original values in CodeCarbon where made by running CodeCarbon on each regions, so it was not representing the real values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inimaz inimaz inimaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Impact Values not Updated for Google cloud
4 participants
@benoit-cty @wielrenner @inimaz @MarionCoutarel