Skip to content

Commit

Permalink
Merge branch 'new-apis_v0.1.0-dev' into new-apis_v0.1.0-dev_more-debu…
Browse files Browse the repository at this point in the history
…g-info
  • Loading branch information
sarthakpati committed May 31, 2024
2 parents 8b92852 + c1909f7 commit c2e5ec3
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 3 deletions.
3 changes: 3 additions & 0 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# These owners will be the default owners for everything in the repo.
# Unless a later match takes precedence,they will be requested for review when someone opens a pull request.
* @mlcommons/gandlf-write
3 changes: 2 additions & 1 deletion .github/workflows/black.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ jobs:
run: |
echo "BLACK_VERSION=$(python -c 'from setup import black_version; print(black_version)')" >> $GITHUB_ENV
- uses: psf/black@stable
# ensure conformity with https://github.com/mlcommons/GaNDLF/blob/master/setup.py#L77
- uses: psf/black@23.11.0
with:
version: ${{ env.BLACK_VERSION }}

Expand Down
2 changes: 1 addition & 1 deletion GANDLF/data/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ def get_train_loader(params):
loader_type="train",
),
batch_size=params["batch_size"],
shuffle=True,
shuffle=False,
pin_memory=False, # params["pin_memory_dataloader"], # this is going OOM if True - needs investigation
)

Expand Down
3 changes: 2 additions & 1 deletion GANDLF/models/Readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,5 @@
- All parameters should be taken as input, with special parameters (for e.g., `residualConnections` for `unet`) should not be exposed to the parameters dict, and should be handled separately via another class.
- For example, `GANDLF.models.unet.unet` has a `residualConnections` parameter, which is not exposed to the parameters dict, and a separate class `GANDLF.models.unet.resunet` is defined which enables this flag.
- Add the model's identifier to `GANDLF.models.__init__.global_model_dict` as appropriate.
- Call the new mode from the config using the `model` key.
- Call the new mode from the config using the `model` key.
- To update the tests, append the new model key to either in `all_models_segmentation`, `all_models_segmentation` or `all_models_classification` in [test_full.py](https://github.com/mlcommons/GaNDLF/blob/master/testing/test_full.py)
2 changes: 2 additions & 0 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,8 @@ def run(self):
"torchinfo==1.7.0",
"segmentation-models-pytorch==0.3.3",
"ACSConv==0.1.1",
# https://github.com/docker/docker-py/issues/3256
"requests<2.32.0", # 2.32.0 are not compatible with docker 7.0.0; to remove restriction once docker is fixed
"docker",
"dicom-anonymizer==1.0.12",
"twine",
Expand Down

0 comments on commit c2e5ec3

Please sign in to comment.