Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to integrate new OPM APIs #261

Merged
merged 10 commits into from
Dec 27, 2021

Conversation

sarthakpati
Copy link
Collaborator

Fixes #N.A.

Proposed Changes

  • updated API for OPM

Checklist

@codecov
Copy link

codecov bot commented Dec 17, 2021

Codecov Report

Merging #261 (a00a07a) into master (5a949da) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #261   +/-   ##
=======================================
  Coverage   87.23%   87.23%           
=======================================
  Files          80       80           
  Lines        4169     4169           
=======================================
  Hits         3637     3637           
  Misses        532      532           
Flag Coverage Δ
unittests 87.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
setup.py 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a949da...a00a07a. Read the comment docs.

@sarthakpati sarthakpati marked this pull request as draft December 17, 2021 20:48
@sarthakpati sarthakpati marked this pull request as ready for review December 19, 2021 03:55
@sarthakpati
Copy link
Collaborator Author

Made a few changes, can you take a look as well, @grenkoca?

@sarthakpati sarthakpati changed the title Opm api update Updates to integrate new OPM APIs Dec 20, 2021
@sarthakpati sarthakpati marked this pull request as draft December 26, 2021 23:45
@sarthakpati
Copy link
Collaborator Author

Folded into #263 to ensure a single merge.

@Geeks-Sid Geeks-Sid merged commit a8dc652 into mlcommons:master Dec 27, 2021
@sarthakpati sarthakpati deleted the opm_api_update branch December 27, 2021 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants