Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using TiffSlide instead of OpenSlide for a better deployment #303

Merged
merged 60 commits into from
Mar 8, 2022

Conversation

sarthakpati
Copy link
Collaborator

@sarthakpati sarthakpati commented Feb 5, 2022

Fixes #54

Proposed Changes

  • openslide is no longer a dependency
  • data for unit tests has now been moved to Penn Box instead of Git LFS
  • patch miner is now a separate function for end-to-end unit testing of histo pipeline
  • requirements updated in setup.py

Checklist

@sarthakpati sarthakpati marked this pull request as draft February 5, 2022 12:45
@sarthakpati
Copy link
Collaborator Author

@Geeks-Sid @grenkoca could one of you please take a look at this? Also, we would need to update the tests to test the histo inference mechanism, which was not covered by unit tests before.

@codecov
Copy link

codecov bot commented Feb 5, 2022

Codecov Report

Merging #303 (5eaab71) into master (b638152) will increase coverage by 2.32%.
The diff coverage is 95.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #303      +/-   ##
==========================================
+ Coverage   88.71%   91.03%   +2.32%     
==========================================
  Files          86       88       +2     
  Lines        4465     4561      +96     
==========================================
+ Hits         3961     4152     +191     
+ Misses        504      409      -95     
Flag Coverage Δ
unittests 91.03% <95.45%> (+2.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
setup.py 0.00% <ø> (ø)
GANDLF/cli/patch_extraction.py 90.47% <90.47%> (ø)
testing/test_full.py 98.68% <93.75%> (-0.22%) ⬇️
GANDLF/compute/inference_loop.py 80.85% <95.12%> (+38.80%) ⬆️
GANDLF/cli/__init__.py 100.00% <100.00%> (ø)
GANDLF/data/inference_dataloader_histopath.py 100.00% <100.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b638152...5eaab71. Read the comment docs.

Geeks-Sid
Geeks-Sid previously approved these changes Feb 13, 2022
@sarthakpati sarthakpati marked this pull request as ready for review March 4, 2022 13:24
@sarthakpati sarthakpati marked this pull request as draft March 4, 2022 13:24
@sarthakpati sarthakpati marked this pull request as ready for review March 8, 2022 16:37
@sarthakpati sarthakpati changed the title OpenSlide changed to TiffSlide Using TiffSlide instead of OpenSlide for a better deployment Mar 8, 2022
@sarthakpati sarthakpati changed the title Using TiffSlide instead of OpenSlide for a better deployment Using TiffSlide instead of OpenSlide for a better deployment Mar 8, 2022
setup.py Show resolved Hide resolved
setup.py Show resolved Hide resolved
Copy link
Collaborator

@Geeks-Sid Geeks-Sid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's address all first.

@Geeks-Sid Geeks-Sid merged commit 34dad4d into mlcommons:master Mar 8, 2022
@sarthakpati sarthakpati deleted the 54_changed-to-tiffslide branch March 8, 2022 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alternatives to OpenSlide
2 participants