Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure ONNX-related print only happens once during training #364

Merged
merged 2 commits into from
Mar 22, 2022

Conversation

sarthakpati
Copy link
Collaborator

@sarthakpati sarthakpati commented Mar 22, 2022

Fixes #N.A.

Proposed Changes

  • added a key in parameter to ensure the print only happens once

Checklist

  • I have read the CONTRIBUTING guide
  • My PR is based from the current GaNDLF master
  • Non-breaking change (would not break existing functionality): please provide as many details as possible for any breaking change
  • Function/class source code documentation added/updated
  • Code has been blacked for style consistency
  • If applicable, version information has been updated in GANDLF/version.py
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file
  • Usage documentation has been updated, if appropriate
  • History has been updated, if appropriate
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3,4]

@sarthakpati sarthakpati changed the title Ensure print only happens once during training Ensure ONNX-related print only happens once during training Mar 22, 2022
@codecov
Copy link

codecov bot commented Mar 22, 2022

Codecov Report

Merging #364 (e3578b9) into master (2ae23ff) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #364   +/-   ##
=======================================
  Coverage   91.23%   91.23%           
=======================================
  Files          89       89           
  Lines        5052     5054    +2     
=======================================
+ Hits         4609     4611    +2     
  Misses        443      443           
Flag Coverage Δ
unittests 91.23% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
GANDLF/utils/modelio.py 79.66% <100.00%> (+0.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ae23ff...e3578b9. Read the comment docs.

@sarthakpati sarthakpati merged commit 7bb82d9 into master Mar 22, 2022
@sarthakpati sarthakpati deleted the sarthakpati-patch-1 branch March 22, 2022 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants