Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated patch divisibility logic #523

Conversation

sarthakpati
Copy link
Collaborator

Fixes #522

Proposed Changes

  • fixed issue of patch divisibility logic failing when unique patch size value is same as check value
  • replaced sys.exit with assert for in-model logic checks for better readability

Checklist

  • I have read the CONTRIBUTING guide
  • My PR is based from the current GaNDLF master
  • Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change
  • Function/class source code documentation added/updated
  • Code has been blacked for style consistency
  • If applicable, version information has been updated in GANDLF/version.py
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file
  • Usage documentation has been updated, if appropriate
  • History has been updated, if appropriate
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3,4]

@github-actions
Copy link
Contributor

github-actions bot commented Nov 16, 2022

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

…ique-patch-size-value-is-same-as-check-value
@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Merging #523 (e8777c8) into master (b423059) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #523      +/-   ##
==========================================
+ Coverage   93.70%   93.72%   +0.02%     
==========================================
  Files         109      109              
  Lines        6891     6886       -5     
==========================================
- Hits         6457     6454       -3     
+ Misses        434      432       -2     
Flag Coverage Δ
unittests 93.72% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
GANDLF/models/deep_unet.py 100.00% <100.00%> (+1.58%) ⬆️
GANDLF/models/light_unet.py 98.24% <100.00%> (+1.69%) ⬆️
GANDLF/models/uinc.py 100.00% <100.00%> (+1.44%) ⬆️
GANDLF/models/unet.py 100.00% <100.00%> (ø)
GANDLF/utils/generic.py 93.24% <100.00%> (ø)
...NDLF/data/preprocessing/template_matching/utils.py 95.34% <0.00%> (-2.33%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AlexanderGetka-cbica AlexanderGetka-cbica merged commit 54cdc71 into mlcommons:master Nov 18, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 18, 2022
@sarthakpati sarthakpati deleted the 522-patch-divisibility-logic-fails-when-unique-patch-size-value-is-same-as-check-value branch November 18, 2022 12:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Patch divisibility logic fails when unique patch size value is same as check value
2 participants