-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated patch divisibility logic #523
Merged
AlexanderGetka-cbica
merged 6 commits into
mlcommons:master
from
sarthakpati:522-patch-divisibility-logic-fails-when-unique-patch-size-value-is-same-as-check-value
Nov 18, 2022
Merged
Updated patch divisibility logic #523
AlexanderGetka-cbica
merged 6 commits into
mlcommons:master
from
sarthakpati:522-patch-divisibility-logic-fails-when-unique-patch-size-value-is-same-as-check-value
Nov 18, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
…ique-patch-size-value-is-same-as-check-value
Codecov Report
@@ Coverage Diff @@
## master #523 +/- ##
==========================================
+ Coverage 93.70% 93.72% +0.02%
==========================================
Files 109 109
Lines 6891 6886 -5
==========================================
- Hits 6457 6454 -3
+ Misses 434 432 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…ique-patch-size-value-is-same-as-check-value
…ique-patch-size-value-is-same-as-check-value
…ique-patch-size-value-is-same-as-check-value
AlexanderGetka-cbica
approved these changes
Nov 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #522
Proposed Changes
sys.exit
withassert
for in-model logic checks for better readabilityChecklist
CONTRIBUTING
guidepip install
step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3,4]