Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a few segmentation metrics #661

Merged
merged 27 commits into from
May 26, 2023

Conversation

sarthakpati
Copy link
Collaborator

Fixes #660

Proposed Changes

  • added metrics for segmentation to enhance interpretation of results

Checklist

  • I have read the CONTRIBUTING guide.
  • My PR is based from the current GaNDLF master .
  • Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change.
  • Function/class source code documentation added/updated.
  • Code has been blacked for style consistency.
  • If applicable, version information has been updated in GANDLF/version.py.
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file.
  • Usage documentation has been updated, if appropriate.
  • History has been updated, if appropriate.
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation.
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].

@github-actions
Copy link
Contributor

github-actions bot commented May 25, 2023

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

Geeks-Sid
Geeks-Sid previously approved these changes May 25, 2023
@Geeks-Sid Geeks-Sid dismissed their stale review May 25, 2023 18:10

Waiting for multi-dim tests

@sarthakpati sarthakpati marked this pull request as draft May 25, 2023 18:29
@sarthakpati sarthakpati mentioned this pull request May 25, 2023
11 tasks
@sarthakpati
Copy link
Collaborator Author

Since the tests in #663 are passing, do you need me to make them work for this as well? Once that PR is merged, this will get automatically closed.

@Geeks-Sid Geeks-Sid merged commit f7f7b9d into mlcommons:master May 26, 2023
13 of 14 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 26, 2023
@sarthakpati sarthakpati deleted the metrics_calculation branch May 26, 2023 23:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a few segmentation-specific metrics
2 participants