Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade openvino version to latest #699

Merged
merged 14 commits into from
Aug 2, 2023

Conversation

Geeks-Sid
Copy link
Collaborator

Update openvino version to 2023.1.0

Proposed Changes

Update openvino version to 2023.1.0

Checklist

  • I have read the CONTRIBUTING guide.
  • My PR is based from the current GaNDLF master .
  • Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change.
  • Function/class source code documentation added/updated.
  • Code has been blacked for style consistency.
  • If applicable, version information has been updated in GANDLF/version.py.
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file.
  • Usage documentation has been updated, if appropriate.
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation.
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].

@github-actions
Copy link
Contributor

github-actions bot commented Jul 28, 2023

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@Geeks-Sid Geeks-Sid changed the title upgrade openvino version Upgrade openvino version to latest Jul 28, 2023
@Geeks-Sid Geeks-Sid marked this pull request as ready for review July 28, 2023 16:43
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #699 (da78085) into master (3c31ab8) will decrease coverage by 0.02%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

❗ Current head da78085 differs from pull request most recent head 285aefd. Consider uploading reports for the commit 285aefd to get more accurate results

@@            Coverage Diff             @@
##           master     #699      +/-   ##
==========================================
- Coverage   94.69%   94.68%   -0.02%     
==========================================
  Files         117      117              
  Lines        8215     8218       +3     
==========================================
+ Hits         7779     7781       +2     
- Misses        436      437       +1     
Flag Coverage Δ
unittests 94.68% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
GANDLF/cli/post_training_model_optimization.py 100.00% <100.00%> (ø)
GANDLF/utils/modelio.py 84.37% <100.00%> (+1.81%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@sarthakpati sarthakpati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting minor changes - should be ready to merge after these are taken care of and any failing tests.

GANDLF/cli/post_training_model_optimization.py Outdated Show resolved Hide resolved
@Geeks-Sid
Copy link
Collaborator Author

@sarthakpati Do you know how i can resolve this test failing?

@sarthakpati
Copy link
Collaborator

@sarthakpati Do you know how i can resolve this test failing?

This usually comes from a stochastic process. I just started a re-run, which should hopefully fix it.

GANDLF/utils/modelio.py Outdated Show resolved Hide resolved
@sarthakpati
Copy link
Collaborator

Apologies, but due to an unforeseen issue, OpenFL tests are failing [ref]. Please hang on tight while we are coordinating a fix, and we will re-initiate the failing run automatically.

sarthakpati
sarthakpati previously approved these changes Aug 1, 2023
Copy link
Collaborator

@sarthakpati sarthakpati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

GANDLF/utils/modelio.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@sarthakpati sarthakpati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

GANDLF/utils/modelio.py Outdated Show resolved Hide resolved
@sarthakpati
Copy link
Collaborator

Can you also remove the line ov_output_dir = os.path.dirname(os.path.abspath(path)) from modelio.py?

GANDLF/utils/modelio.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@sarthakpati sarthakpati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes to fix codacy issues

Geeks-Sid and others added 2 commits August 2, 2023 09:39
Co-authored-by: Sarthak Pati <sarthak.pati@pennmedicine.upenn.edu>
Copy link
Collaborator

@sarthakpati sarthakpati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sarthakpati sarthakpati merged commit 6d901ee into mlcommons:master Aug 2, 2023
14 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants