Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated checkout version and test names for clarity #708

Merged
merged 6 commits into from
Aug 7, 2023

Conversation

sarthakpati
Copy link
Collaborator

@sarthakpati sarthakpati commented Aug 6, 2023

Fixes #N.A.

Proposed Changes

  • updated checkout version to fix GH warning
  • updated test names for clarity (this is also updated in the list of required tests to pass)

Checklist

  • I have read the CONTRIBUTING guide.
  • My PR is based from the current GaNDLF master .
  • Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change.
  • Function/class source code documentation added/updated.
  • Code has been blacked for style consistency.
  • If applicable, version information has been updated in GANDLF/version.py.
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file.
  • Usage documentation has been updated, if appropriate.
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation.
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].

@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2023

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@sarthakpati sarthakpati marked this pull request as draft August 6, 2023 14:07
@sarthakpati sarthakpati marked this pull request as ready for review August 6, 2023 14:10
Geeks-Sid
Geeks-Sid previously approved these changes Aug 6, 2023
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #708 (e95f6b1) into master (c2040ea) will not change coverage.
Report is 3 commits behind head on master.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #708   +/-   ##
=======================================
  Coverage   94.68%   94.68%           
=======================================
  Files         117      117           
  Lines        8228     8228           
=======================================
  Hits         7791     7791           
  Misses        437      437           
Flag Coverage Δ
unittests 94.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@Geeks-Sid Geeks-Sid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sarthakpati sarthakpati merged commit 8c0d298 into master Aug 7, 2023
17 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 7, 2023
@sarthakpati sarthakpati deleted the sarthakpati-patch-2 branch August 7, 2023 18:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants