-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy model entrypoint #711
Deploy model entrypoint #711
Conversation
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
Codecov Report
@@ Coverage Diff @@
## master #711 +/- ##
==========================================
+ Coverage 94.71% 94.72% +0.01%
==========================================
Files 117 117
Lines 8243 8251 +8
==========================================
+ Hits 7807 7816 +9
+ Misses 436 435 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The aim is to have flexibility in creating model MLCubes from GaNDLF models. The user can now provide a custom entrypoint script for the MLCube which can act as a wrapper around calling gandlf_run. The goal is to NOT rely on having data input folder containing a csv file. Using a custom script, the model author can build a csv file before calling gandlf_run.
Proposed Changes
Checklist
CONTRIBUTING
guide.pip install
step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].