Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added parameter to toggle NCC computation #717

Merged

Conversation

FelixSteinbauer
Copy link
Contributor

Introduced a parameter (compute_ncc, defaut=True) that allows to turn off the (time-consuming) computation of the 4 NCC metrics.

Checklist

  • I have read the CONTRIBUTING guide.
  • My PR is based from the current GaNDLF master .
  • Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change.
  • Function/class source code documentation added/updated.
  • Code has been blacked for style consistency.
  • If applicable, version information has been updated in GANDLF/version.py.
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file.
  • Usage documentation has been updated, if appropriate.
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation.
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].

Introduced a parameter (compute_ncc, defaut=True) that allows to turn off the (time-consuming) computation of the 4 NCC metrics.
@github-actions
Copy link
Contributor

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #717 (bc0d3fa) into master (32fd05c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #717   +/-   ##
=======================================
  Coverage   94.72%   94.72%           
=======================================
  Files         117      117           
  Lines        8251     8253    +2     
=======================================
+ Hits         7816     7818    +2     
  Misses        435      435           
Flag Coverage Δ
unittests 94.72% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
GANDLF/cli/generate_metrics.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sarthakpati sarthakpati self-requested a review August 24, 2023 23:07
Copy link
Collaborator

@sarthakpati sarthakpati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FelixSteinbauer
Copy link
Contributor Author

@sarthakpati sorry to bother you again: I don't really know how to solve the "Dev-Container CI" error. I don't see how that is connected to to changes I made and I would not know where to start resolving this... Similarly the "Codacy Static Code Analysis", how can I make the PR pass this one?

@sarthakpati
Copy link
Collaborator

@sarthakpati sorry to bother you again: I don't really know how to solve the "Dev-Container CI" error. I don't see how that is connected to to changes I made and I would not know where to start resolving this... Similarly the "Codacy Static Code Analysis", how can I make the PR pass this one?

Hey, the dev container ci is indeed unrelated, so we can ignore it. The codacy will just take some time. I'll reach out to them to see what the status is. Nothing for you to do!

@sarthakpati sarthakpati merged commit 72eb99f into mlcommons:master Aug 28, 2023
16 of 17 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants