Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combined writing and temp file creation in a single step #720

Merged
merged 5 commits into from
Sep 14, 2023

Conversation

sarthakpati
Copy link
Collaborator

@sarthakpati sarthakpati commented Sep 11, 2023

This change will combine the creation of a temporary file and writing of the parameters in a single step, thereby reducing the total number of lines in the testing file.

Fixes #N.A.

Proposed Changes

  • reducing number of lines for code coverage

Checklist

  • I have read the CONTRIBUTING guide.
  • My PR is based from the current GaNDLF master .
  • Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change.
  • Function/class source code documentation added/updated.
  • Code has been blacked for style consistency.
  • If applicable, version information has been updated in GANDLF/version.py.
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file.
  • Usage documentation has been updated, if appropriate.
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation.
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].

This change will combine the creation of a temporary file and writing of the parameters in a single step, thereby reducing the total number of lines in the testing file.
@sarthakpati sarthakpati marked this pull request as draft September 11, 2023 08:14
@github-actions
Copy link
Contributor

github-actions bot commented Sep 11, 2023

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #720 (3911c26) into master (60c9d28) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #720      +/-   ##
==========================================
- Coverage   94.71%   94.70%   -0.01%     
==========================================
  Files         117      117              
  Lines        8251     8219      -32     
==========================================
- Hits         7815     7784      -31     
+ Misses        436      435       -1     
Flag Coverage Δ
unittests 94.70% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
testing/test_full.py 99.15% <100.00%> (-0.02%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sarthakpati sarthakpati marked this pull request as ready for review September 11, 2023 17:04
@Geeks-Sid Geeks-Sid merged commit b230e02 into master Sep 14, 2023
17 of 18 checks passed
@Geeks-Sid Geeks-Sid deleted the sarthakpati-patch-2 branch September 14, 2023 01:38
@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants