Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add schedulers monai #807

Merged
merged 20 commits into from
Mar 13, 2024
Merged

Conversation

Ainesh06102004
Copy link
Contributor

Fixes #805

Proposed Changes

  • added WarmupCosineSchedule

Checklist

  • CONTRIBUTING guide has been followed.
  • PR is based on the current GaNDLF master .
  • Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change.
  • [] Function/class source code documentation added/updated (ensure typing is used to provide type hints, including and not limited to using Optional if a variable has a pre-defined value).
  • Code has been blacked for style consistency and linting.
  • If applicable, version information has been updated in GANDLF/version.py.
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file.
  • Usage documentation has been updated, if appropriate.
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation.
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].

Copy link
Contributor

github-actions bot commented Mar 3, 2024

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@Ainesh06102004 Ainesh06102004 changed the title Add optimizers monai Add schedulers monai Mar 4, 2024
@Ainesh06102004 Ainesh06102004 marked this pull request as ready for review March 12, 2024 12:52
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.02%. Comparing base (64962a1) to head (b2482ea).

❗ Current head b2482ea differs from pull request most recent head 3ca6792. Consider uploading reports for the commit 3ca6792 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #807      +/-   ##
==========================================
- Coverage   95.05%   95.02%   -0.03%     
==========================================
  Files         119      120       +1     
  Lines        8288     8267      -21     
==========================================
- Hits         7878     7856      -22     
- Misses        410      411       +1     
Flag Coverage Δ
unittests 95.02% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@sarthakpati sarthakpati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting minor changes.

GANDLF/schedulers/wrap_torch.py Outdated Show resolved Hide resolved
GANDLF/schedulers/wrap_monai.py Outdated Show resolved Hide resolved
GANDLF/schedulers/wrap_monai.py Outdated Show resolved Hide resolved
GANDLF/schedulers/__init__.py Outdated Show resolved Hide resolved
Ainesh06102004 and others added 5 commits March 12, 2024 19:20
Co-authored-by: Sarthak Pati <patis@iu.edu>
Co-authored-by: Sarthak Pati <patis@iu.edu>
Co-authored-by: Sarthak Pati <patis@iu.edu>
Co-authored-by: Sarthak Pati <patis@iu.edu>
Copy link
Collaborator

@sarthakpati sarthakpati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sarthakpati sarthakpati merged commit a934324 into mlcommons:master Mar 13, 2024
19 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add WarmupCosineSchdule Scheduler
2 participants