Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added readme for running tests locally #827

Merged
merged 8 commits into from
Mar 22, 2024

Conversation

VukW
Copy link
Contributor

@VukW VukW commented Mar 21, 2024

Proposed Changes

  • Added readme that explains additional steps, required for running tests locally

Checklist

  • CONTRIBUTING guide has been followed.
  • PR is based on the current GaNDLF master .
  • Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change.
  • Function/class source code documentation added/updated (ensure typing is used to provide type hints, including and not limited to using Optional if a variable has a pre-defined value).
  • Code has been blacked for style consistency and linting.
  • If applicable, version information has been updated in GANDLF/version.py.
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file.
  • Usage documentation has been updated, if appropriate.
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation.
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].

Copy link
Contributor

github-actions bot commented Mar 21, 2024

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 95.03%. Comparing base (702194a) to head (3e28c63).
Report is 1 commits behind head on master.

Files Patch % Lines
testing/test_full.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #827      +/-   ##
==========================================
- Coverage   95.04%   95.03%   -0.02%     
==========================================
  Files         120      120              
  Lines        8268     8270       +2     
==========================================
+ Hits         7858     7859       +1     
- Misses        410      411       +1     
Flag Coverage Δ
unittests 95.03% <75.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@sarthakpati sarthakpati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Can you put these instructions in this document [ref] so that it gets rendered in HTML? And refer to this link in this README.

testing/README.md Outdated Show resolved Hide resolved
@VukW
Copy link
Contributor Author

VukW commented Mar 21, 2024

@sarthakpati Thanks for the link, didn't find when was searching!
Moved "readme" to main doc as you proposed.

@VukW
Copy link
Contributor Author

VukW commented Mar 22, 2024

@sarthakpati

The only check that is failing right now is codecov - because of reduced coverage. However, because my changes are in the test itself, it should be ok.
Therefore, I believe, PR is ready. May I ask you to review it again. please?

docs/extending.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@sarthakpati sarthakpati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting minor change. Should be good to go after this.

sarthakpati and others added 2 commits March 22, 2024 09:41
Copy link
Collaborator

@sarthakpati sarthakpati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sarthakpati sarthakpati merged commit 3e0480a into mlcommons:master Mar 22, 2024
19 of 21 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants