Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger tests for pull requests to all branches #855

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

sarthakpati
Copy link
Collaborator

Fixes #ISSUE_NUMBER

Proposed Changes

  • ensure tests are triggered for pull requests initiated to all branches

Checklist

  • CONTRIBUTING guide has been followed.
  • PR is based on the current GaNDLF master .
  • Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change.
  • Function/class source code documentation added/updated (ensure typing is used to provide type hints, including and not limited to using Optional if a variable has a pre-defined value).
  • Code has been blacked for style consistency and linting.
  • If applicable, version information has been updated in GANDLF/version.py.
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file.
  • Usage documentation has been updated, if appropriate.
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation.
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].

@sarthakpati sarthakpati requested a review from VukW April 23, 2024 20:48
Copy link
Contributor

github-actions bot commented Apr 23, 2024

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@sarthakpati sarthakpati changed the base branch from master to new-apis_v0.1.0-dev April 23, 2024 20:49
@VukW
Copy link
Contributor

VukW commented Apr 23, 2024

Hmm
It seems to me that you are disabling these checks on any PR, aren't you? Say, this PR doesn't run checks anymore

@VukW
Copy link
Contributor

VukW commented Apr 23, 2024

GPT says triggers should look like

on:
  push:
    branches: [ master ]
  pull_request: {}

@sarthakpati
Copy link
Collaborator Author

pull_request: {}

Awesome, thanks!

Copy link
Contributor

@VukW VukW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.41%. Comparing base (e674f47) to head (8efb957).

Additional details and impacted files
@@                   Coverage Diff                   @@
##           new-apis_v0.1.0-dev     #855      +/-   ##
=======================================================
+ Coverage                94.40%   94.41%   +0.01%     
=======================================================
  Files                      158      158              
  Lines                     9345     9345              
=======================================================
+ Hits                      8822     8823       +1     
+ Misses                     523      522       -1     
Flag Coverage Δ
unittests 94.41% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sarthakpati sarthakpati merged commit 690c9e9 into new-apis_v0.1.0-dev Apr 24, 2024
25 checks passed
@sarthakpati sarthakpati deleted the new-apis_v0.1.0-dev_trigger_tests branch April 24, 2024 13:42
@github-actions github-actions bot locked and limited conversation to collaborators Apr 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants