Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PyTorch dependency #857

Merged
merged 6 commits into from
Apr 24, 2024

Conversation

scap3yvt
Copy link
Collaborator

@scap3yvt scap3yvt commented Apr 24, 2024

Fixes #856

Proposed Changes

  • updated pytorch and torchio versions in setup
  • made analogoes updates for docker files
  • updated relevant documentation

Checklist

  • CONTRIBUTING guide has been followed.
  • PR is based on the current GaNDLF master .
  • Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change.
  • Function/class source code documentation added/updated (ensure typing is used to provide type hints, including and not limited to using Optional if a variable has a pre-defined value).
  • Code has been blacked for style consistency and linting.
  • If applicable, version information has been updated in GANDLF/version.py.
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file.
  • Usage documentation has been updated, if appropriate.
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation.
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].

Copy link
Contributor

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@sarthakpati sarthakpati changed the title Update dependencies Update PyTorch dependency Apr 24, 2024
@sarthakpati sarthakpati self-requested a review April 24, 2024 16:29
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.40%. Comparing base (690c9e9) to head (5ea23cf).

Additional details and impacted files
@@                   Coverage Diff                   @@
##           new-apis_v0.1.0-dev     #857      +/-   ##
=======================================================
- Coverage                94.41%   94.40%   -0.02%     
=======================================================
  Files                      158      158              
  Lines                     9345     9345              
=======================================================
- Hits                      8823     8822       -1     
- Misses                     522      523       +1     
Flag Coverage Δ
unittests 94.40% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@sarthakpati sarthakpati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sarthakpati sarthakpati merged commit 2ed393d into new-apis_v0.1.0-dev Apr 24, 2024
26 of 27 checks passed
@sarthakpati sarthakpati deleted the new-apis_v0.1.0-dev_pytorch221 branch April 24, 2024 19:55
@github-actions github-actions bot locked and limited conversation to collaborators Apr 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants