Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dynunet model #873

Merged
merged 30 commits into from
Jun 18, 2024

Conversation

benmalef
Copy link
Contributor

@benmalef benmalef commented May 24, 2024

Brief description

This PR adds the dynunet model.

Proposed Changes

  • Add the dynunet model.
  • Create a new file dynunet_wrapper in the models dir.
  • Update the test_full file.

Important notes
I have added a docker-compose file.
It is used for development purposes. I will delete it when the task is completed.

Checklist

  • CONTRIBUTING guide has been followed.
  • PR is based on the current GaNDLF master .
  • Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change.
  • Function/class source code documentation added/updated (ensure typing is used to provide type hints, including and not limited to using Optional if a variable has a pre-defined value).
  • Code has been blacked for style consistency and linting.
  • If applicable, version information has been updated in GANDLF/version.py.
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file.
  • Usage documentation has been updated, if appropriate.
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation.
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].

Copy link
Contributor

github-actions bot commented May 24, 2024

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

docker-compose.yaml Outdated Show resolved Hide resolved
@benmalef benmalef requested a review from sarthakpati May 30, 2024 16:19
GANDLF/models/__init__.py Outdated Show resolved Hide resolved
GANDLF/models/dynunet_wrapper.py Outdated Show resolved Hide resolved
GANDLF/models/dynunet_wrapper.py Outdated Show resolved Hide resolved
GANDLF/models/dynunet_wrapper.py Outdated Show resolved Hide resolved
GANDLF/models/dynunet_wrapper.py Outdated Show resolved Hide resolved
testing/config_segmentation.yaml Outdated Show resolved Hide resolved
testing/test_full.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jun 1, 2024

Codecov Report

Attention: Patch coverage is 94.59459% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.41%. Comparing base (83795aa) to head (86e4188).

Current head 86e4188 differs from pull request most recent head 48abb3e

Please upload reports for the commit 48abb3e to get more accurate results.

Files Patch % Lines
GANDLF/models/dynunet_wrapper.py 92.85% 2 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                   @@
##           new-apis_v0.1.0-dev     #873      +/-   ##
=======================================================
- Coverage                94.41%   94.41%   -0.01%     
=======================================================
  Files                      158      159       +1     
  Lines                     9314     9349      +35     
=======================================================
+ Hits                      8794     8827      +33     
- Misses                     520      522       +2     
Flag Coverage Δ
unittests 94.41% <94.59%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benmalef benmalef marked this pull request as ready for review June 1, 2024 15:14
@benmalef benmalef requested a review from a team as a code owner June 1, 2024 15:14
GANDLF/models/dynunet_wrapper.py Outdated Show resolved Hide resolved
GANDLF/models/dynunet_wrapper.py Outdated Show resolved Hide resolved
GANDLF/models/dynunet_wrapper.py Outdated Show resolved Hide resolved
GANDLF/models/dynunet_wrapper.py Outdated Show resolved Hide resolved
GANDLF/models/dynunet_wrapper.py Outdated Show resolved Hide resolved
GANDLF/models/dynunet_wrapper.py Outdated Show resolved Hide resolved
GANDLF/models/dynunet_wrapper.py Outdated Show resolved Hide resolved
testing/test_full.py Outdated Show resolved Hide resolved
@benmalef
Copy link
Contributor Author

benmalef commented Jun 5, 2024

@sarthakpati I made the proposed changes.
Thanks for the review.

@benmalef
Copy link
Contributor Author

Hi @sarthakpati,
I believe that it is ready for merging.

@sarthakpati sarthakpati merged commit 6a38171 into mlcommons:new-apis_v0.1.0-dev Jun 18, 2024
19 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 18, 2024
@benmalef benmalef deleted the add_dynunet_model branch June 26, 2024 08:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants