Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

et_converter: Support Chakra v0.0.4 in text2chakra converter #9

Merged
merged 1 commit into from
Feb 6, 2024
Merged

et_converter: Support Chakra v0.0.4 in text2chakra converter #9

merged 1 commit into from
Feb 6, 2024

Conversation

changhai0109
Copy link
Contributor

Summary

Update text converter to use v0.0.4 schema

Test Plan

# Assuming there is a astrasim text input file, like [astrasim]/inputs/workload/ASTRA-sim-1.0/Resnet50_DataParallel.txt
python -m chakra.et_converter.et_converter \
    --input_type Text \
    --input_filename ${ASTRASIM_DIR}/inputs/workload/ASTRA-sim-1.0/Resnet50_DataParallel.txt \
    --output_filename Resnet50_DataParallel \
    --num_dims 1 \
    --num_npus 64 \
    --num_passes 1

@changhai0109 changhai0109 requested a review from a team as a code owner December 12, 2023 00:04
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 12, 2023 •
edited

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@changhai0109 changhai0109 mentioned this pull request Jan 22, 2024
Closed
@TaekyungHeo TaekyungHeo changed the title [ETConverter] Update text converter to new schema et_converter: Support Chakra v0.0.4 in text2chakra converter Feb 6, 2024
@TaekyungHeo
Copy link
Contributor

Looks good to me. I confirmed that the provided test case works.

@TaekyungHeo TaekyungHeo self-requested a review February 6, 2024 19:45
@srinivas212 srinivas212 merged commit 0e9df72 into mlcommons:main Feb 6, 2024
3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@srinivas212 srinivas212 srinivas212 approved these changes

@TaekyungHeo TaekyungHeo Awaiting requested review from TaekyungHeo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@changhai0109 @TaekyungHeo @srinivas212