Skip to content

Commit

Permalink
Remove loadgen warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
pgmpablo157321 committed Feb 5, 2024
1 parent 473053f commit 86bfe86
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
2 changes: 2 additions & 0 deletions loadgen/results.cc
Original file line number Diff line number Diff line change
Expand Up @@ -431,6 +431,8 @@ void PerformanceSummary::LogSummary(AsyncSummary& summary) {
summary("Tokens per second: ", tokens_per_second);
break;
}
case TestScenario::Server:
break;
}
}

Expand Down
3 changes: 2 additions & 1 deletion loadgen/test_settings_internal.cc
Original file line number Diff line number Diff line change
Expand Up @@ -690,12 +690,13 @@ int TestSettings::FromConfig(const std::string &path, const std::string &model,
lookupkv(model, scenario, "test05_schedule_rng_seed", &test05_schedule_rng_seed, nullptr);

// keys that apply to token metrics
if (lookupkv(model, scenario, "use_token_latencies", &val, nullptr))
if (lookupkv(model, scenario, "use_token_latencies", &val, nullptr)){
use_token_latencies = (val == 1) ? true : false;
if (use_token_latencies){
lookupkv(model, "Server", "ttft_latency", &server_ttft_latency, nullptr, 1000 * 1000);
lookupkv(model, "Server", "tpot_latency", &server_tpot_latency, nullptr, 1000 * 1000);
}
}

// keys that apply to SingleStream
lookupkv(model, "SingleStream", "target_latency_percentile", nullptr,
Expand Down
4 changes: 2 additions & 2 deletions loadgen/test_settings_internal.h
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,8 @@ struct TestSettingsInternal {

bool sample_concatenate_permutation;
bool use_token_latencies = false;
uint64_t server_ttft_latency;
uint64_t server_tpot_latency;
int64_t server_ttft_latency;
int64_t server_tpot_latency;
};

/// \brief A namespace of collections of FindPeakPerformance helper functions,
Expand Down

0 comments on commit 86bfe86

Please sign in to comment.