Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update openimages script #1277

Merged
merged 2 commits into from
Nov 8, 2022
Merged

Conversation

pgmpablo157321
Copy link
Contributor

Fixes #1257
Remove the fiftyone package dependency and update the openimages.py and openimages_calibration.py scripts

@github-actions
Copy link

github-actions bot commented Nov 3, 2022

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@pgmpablo157321 pgmpablo157321 force-pushed the openimages_script branch 2 times, most recently from 584eb48 to 27223ff Compare November 3, 2022 22:23
@arjunsuresh
Copy link
Contributor

LGTM. New preprocessing script is working as expected.

@arjunsuresh
Copy link
Contributor

Hi @pgmpablo157321 Thanks for the very useful change. Can we have an option to download a subset of dataset (say 500 images)? I was trying to add a Github test for retinanet and downloading and preprocessing the dataset takes about an hour (on a 48 core machine).

@pgmpablo157321
Copy link
Contributor Author

@arjunsuresh I just added a flag to do that. You can now run the script: ./openimages_calibration_mlperf -d <DOWNLOAD_PATH> -m <MAX_IMAGES>

@arjunsuresh
Copy link
Contributor

Thanks a lot @pgmpablo157321 This change can save hours of effort for the submitters :)

Copy link
Contributor

@arjunsuresh arjunsuresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @pgmpablo157321 for the fix.

@rnaidu02 rnaidu02 merged commit 986ade9 into mlcommons:master Nov 8, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2022
@pgmpablo157321 pgmpablo157321 deleted the openimages_script branch November 8, 2022 17:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simpler download script for openimages
3 participants