Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove loadgen warnings #1608

Merged
merged 2 commits into from
Feb 7, 2024
Merged

Remove loadgen warnings #1608

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1fbad0b
Remove loadgen warnings
pgmpablo157321 Feb 5, 2024
027b59f
Merge branch 'master' into loadgen_warnings
mrmhodak Feb 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions loadgen/results.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,6 +439,8 @@ void PerformanceSummary::LogSummary(AsyncSummary& summary) {
summary("Tokens per second: ", tokens_per_second);
break;
}
case TestScenario::Server:
break;
}
}

Expand Down
3 changes: 2 additions & 1 deletion loadgen/test_settings_internal.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -690,12 +690,13 @@ int TestSettings::FromConfig(const std::string &path, const std::string &model,
lookupkv(model, scenario, "test05_schedule_rng_seed", &test05_schedule_rng_seed, nullptr);

// keys that apply to token metrics
if (lookupkv(model, scenario, "use_token_latencies", &val, nullptr))
if (lookupkv(model, scenario, "use_token_latencies", &val, nullptr)){
use_token_latencies = (val == 1) ? true : false;
if (use_token_latencies){
lookupkv(model, "Server", "ttft_latency", &server_ttft_latency, nullptr, 1000 * 1000);
lookupkv(model, "Server", "tpot_latency", &server_tpot_latency, nullptr, 1000 * 1000);
}
}

// keys that apply to SingleStream
lookupkv(model, "SingleStream", "target_latency_percentile", nullptr,
Expand Down
4 changes: 2 additions & 2 deletions loadgen/test_settings_internal.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,8 @@ struct TestSettingsInternal {

bool sample_concatenate_permutation;
bool use_token_latencies = false;
uint64_t server_ttft_latency;
uint64_t server_tpot_latency;
int64_t server_ttft_latency;
int64_t server_tpot_latency;
};

/// \brief A namespace of collections of FindPeakPerformance helper functions,
Expand Down
Loading