Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop client config file #18

Closed
Lilit1122 opened this issue Dec 22, 2020 · 0 comments · Fixed by #30
Closed

Drop client config file #18

Lilit1122 opened this issue Dec 22, 2020 · 0 comments · Fixed by #30
Labels
enhancement New feature or request
Projects
MLCommons Power Measurement

Comments

@Lilit1122
Copy link
Contributor

Lilit1122 commented Dec 22, 2020 •
edited
Loading

After #8, client options could be passed both as CLI arguments and through the config file.
Probably, now we may drop the config file, preserving only command-line options.
(closes #18)
@Lilit1122 Lilit1122 created this issue from a note in MLCommons Power Measurement (Blocker opened question) Dec 22, 2020
@xzfc xzfc changed the title Drop client config file. Recently we added command line options to the client as an alternative to the config file. May we drop the config file at all, preserving only command line options? Drop client config file for the client Dec 22, 2020
@xzfc xzfc added the question Further information is requested label Dec 22, 2020
@xzfc xzfc changed the title Drop client config file for the client Drop client config file Dec 22, 2020
@xzfc xzfc mentioned this issue Dec 22, 2020
Closed
xzfc added a commit to xzfc/mlcommons-power that referenced this issue Dec 22, 2020
@xzfc
Remove json config, rename CLI opts and other fixes
15a9d2f 
* Rename client CLI options to make it more consitent
* Remove client json config (closes mlcommons#18)
* Update README
* Add warnings when default --label or --port are used (closes mlcommons#27)
* Consistent error messages (closes mlcommons#28)
@xzfc xzfc mentioned this issue Dec 22, 2020
Merged
@Lilit1122 Lilit1122 moved this from Blocker opened question to Done for today in MLCommons Power Measurement Dec 23, 2020
@Lilit1122 Lilit1122 added enhancement New feature or request and removed question Further information is requested labels Dec 23, 2020
@Lilit1122 Lilit1122 moved this from Done for today to Done in MLCommons Power Measurement Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
MLCommons Power Measurement
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove json config, rename CLI opts and other fixes xzfc/mlcommons-power
2 participants
@xzfc @Lilit1122