Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #24 #51

Merged
merged 6 commits into from
Dec 19, 2020
Merged

Fixes #24 #51

merged 6 commits into from
Dec 19, 2020

Conversation

ashok-arora
Copy link
Member

@ashok-arora ashok-arora commented Dec 18, 2020

Fixes #24

Adds custom make targets: example and bench

From now,
make or make all will compile examples/ and benchmark/
make example will compile examples/
make bench will compile benchmark/

@ashok-arora ashok-arora changed the title Fixes #40 Fixes #28 Dec 18, 2020
@ashok-arora ashok-arora changed the title Fixes #28 Fixes #24 Dec 18, 2020
Adds custom make targets: example and bench

From now,
    `make` or `make all` will compile examples/ and benchmark/
    `make example` will compile examples/
    `make bench` will compile benchmark/
@aniketsharma00411
Copy link
Member

Fixes #24

Adds custom make targets: example and bench

From now,
make or make all will compile examples/ and benchmark/
make example will compile examples/
make bench will compile benchmark/

Can we change make bench to make benchmark?

@ashok-arora
Copy link
Member Author

Fixes #24
Adds custom make targets: example and bench
From now,
make or make all will compile examples/ and benchmark/
make example will compile examples/
make bench will compile benchmark/

Can we change make bench to make benchmark?

No, In the CMakeLists.txt file benchmark is being used to link google benchmark library, hence name collision will occur.

@aniketsharma00411
Copy link
Member

aniketsharma00411 commented Dec 18, 2020

Fixes #24
Adds custom make targets: example and bench
From now,
make or make all will compile examples/ and benchmark/
make example will compile examples/
make bench will compile benchmark/

Can we change make bench to make benchmark?

No, In the CMakeLists.txt file benchmark is being used to link google benchmark library, hence name collision will occur.

What about make benchmarks?

@ashok-arora
Copy link
Member Author

What about make benchmarks?

Yes, that can be done.

But in that case, to be consistent, the following changes would also be made:
make examplemake examples
make testmake tests
make docmake docs

Is that okay?

@aniketsharma00411
Copy link
Member

What about make benchmarks?

Yes, that can be done.

But in that case, to be consistent, the following changes would also be made:
make examplemake examples
make testmake tests
make docmake docs

Is that okay?

Yeah, its fine.

@aniketsharma00411
Copy link
Member

What about make benchmarks?

Yes, that can be done.

But in that case, to be consistent, the following changes would also be made:
make examplemake examples
make testmake tests
make docmake docs

Is that okay?

What will make docs do?

@ashok-arora
Copy link
Member Author

What will make docs do?

It will generate/re-generate documentation after modification when adding new code comments.

Adds custom make targets: examples and benchmarks

From now,
`make` or `make all` will compile examples/ and benchmarks/
`make examples` will compile examples/
`make benchmarks` will compile benchmarks/

Also, `benchmark` folder has been renamed to `benchmarks`.
@ashok-arora
Copy link
Member Author

I have made the changes. You may review it.

@aniketsharma00411 aniketsharma00411 merged commit 1c2ed66 into mlcpp:main Dec 19, 2020
@ashok-arora ashok-arora deleted the issue-24 branch January 2, 2021 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build system for benchmarking files
2 participants