Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build system for benchmarking files #24

Closed
aniketsharma00411 opened this issue Nov 29, 2020 · 3 comments · Fixed by #51
Closed

Build system for benchmarking files #24

aniketsharma00411 opened this issue Nov 29, 2020 · 3 comments · Fixed by #51
Assignees
@ashok-arora
Labels
benchmarks Issues concerning Google Benchmarks CMake Issues concerning CMake build system enhancement New feature or request
Projects
Timeline

Comments

@aniketsharma00411
Copy link
Member

The current build system does not compile the benchmarking files present in the benchmark/ directory.

The directory structure will be

/Matrix
  /benchmark
    /linux_binaries
    /macos_binaries
    /windows_executables
    ...
  ...

When in Matrix/benchmark/ the command used to compile will be

g++ <file_name>.cpp -std=c++11 -I../include/ -isystem ../lib/benchmark/include -L../lib/benchmark/build/src -lbenchmark -lpthread -o ./linux_binaries/<file_name>
@aniketsharma00411 aniketsharma00411 added the enhancement New feature or request label Nov 29, 2020
@ashok-arora ashok-arora added benchmarks Issues concerning Google Benchmarks CMake Issues concerning CMake build system labels Nov 29, 2020
@ashok-arora ashok-arora added this to Todo in Timeline Nov 30, 2020
@aniketsharma00411
Copy link
Member Author

@ashok-arora Won't it be better instead of storing binaries for each OS we create a build folder like examples and add it in .gitignore?

@ashok-arora
Copy link
Member

Yes, let's do that. How about using a folder structure like so?

build/
     examples/
     benchmark/

@aniketsharma00411
Copy link
Member Author

Yes, let's do that. How about using a folder structure like so?

build/
     examples/
     benchmark/

This is better.

@ashok-arora ashok-arora moved this from Todo to In progress in Timeline Dec 6, 2020
@ashok-arora ashok-arora mentioned this issue Dec 18, 2020
Merged
ashok-arora added a commit to ashok-arora/Matrix that referenced this issue Dec 18, 2020
@ashok-arora
Fixes mlcpp#24
fbc64d7 
Adds custom make targets: example and bench

From now,
    `make` or `make all` will compile examples/ and benchmark/
    `make example` will compile examples/
    `make bench` will compile benchmark/
ashok-arora added a commit to ashok-arora/Matrix that referenced this issue Dec 19, 2020
@ashok-arora
Fixes mlcpp#24
1da5aa8 
Adds custom make targets: examples and benchmarks

From now,
`make` or `make all` will compile examples/ and benchmarks/
`make examples` will compile examples/
`make benchmarks` will compile benchmarks/

Also, `benchmark` folder has been renamed to `benchmarks`.
aniketsharma00411 pushed a commit that referenced this issue Dec 19, 2020
@ashok-arora
Fixes #24
1c2ed66 
Adds custom make targets: examples and benchmarks
From now,
`make` or `make all` will compile examples/ and benchmarks/
`make examples` will compile examples/
`make benchmarks` will compile benchmarks/
Also, benchmark folder has been renamed to benchmarks.
@aniketsharma00411 aniketsharma00411 moved this from In progress to Done in Timeline Dec 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ashok-arora ashok-arora

Labels
benchmarks Issues concerning Google Benchmarks CMake Issues concerning CMake build system enhancement New feature or request
Projects
Timeline
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #24 ashok-arora/Matrix
2 participants
@ashok-arora @aniketsharma00411