Request added to response and response error #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcrohloff
reviewed
Sep 17, 2020
| // Register fetch call | ||
| promise = promise.then(args => fetch(...args)); | ||
| promise = promise.then(args => { |
There was a problem hiding this comment.
Is this safe in race conditions? i.e. what happens if a second fetch is started before the first one returns
There was a problem hiding this comment.
Thats correct we need to nest the a second promise that extends the response object. Then you can use const request instead of let which gives additional safety in this regard.
|
Can this be accepted ? I need this on my project 👍 |
|
I can't. The current implementation is not save for concurrent requests. |
|
I've made the modification, hope that is the expected one |
neorel
force-pushed
the
request_in_response_for_resend
branch
2 times, most recently
from
3e93dfb
to
d3f546f
Compare
neorel
force-pushed
the
request_in_response_for_resend
branch
from
d3f546f
to
6a069f0
Compare
mlegenhausen
requested changes
Jun 1, 2021
|
Is that the right way, I don't usually use typescript. |
mlegenhausen
changed the title
|
Released in 2.4.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the request in the response.
It help when you intercept an error and want to resend the request.
(I used to work like this with axios, and this feature is missing with fetch)
PS: Hope the commit history is now clean enough ;)