Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we use mapping after dex build to map the error ? #8

Open
thegarlynch opened this issue Jan 20, 2021 · 2 comments
Open

Can we use mapping after dex build to map the error ? #8

thegarlynch opened this issue Jan 20, 2021 · 2 comments

Comments

@thegarlynch
Copy link

Usually after minifyEnabled every code is shortened according to proguard rules. using the same mechanism of crashlytics. can we use it to map the error ? or is it making mapping dex become a bit useless after loading mapping file ?

@mlegy
Copy link
Owner

mlegy commented Apr 5, 2021

Thanks for taking the time to share your suggestion!

The library is not supposed to be enabled in release builds but only debug builds and usually in debug builds people don't enable proguard, so I don't think we need to do this.

Let me know what you think.

@thegarlynch
Copy link
Author

thegarlynch commented Apr 6, 2021

I think since moshi or other library tends to have some miscofiguration at runtime after dex build. This could be useful, crashlytics or any similar app have built this already, albeit with upload dex mapping mechanism. Well, the best way is to just archive it with application together. (But off course, not for release mode). I would help however i can

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants