Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing slickgrid resize causes scrollbar gap near bottom: #1030

Closed
wants to merge 2 commits into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions slick.grid.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
* and do proper cleanup.
*/

// Just testing this to show kenny cool git stuff.
// make sure required JavaScript modules are loaded
if (typeof jQuery === "undefined") {
throw "SlickGrid requires jquery module to be loaded";
Expand Down Expand Up @@ -413,7 +414,7 @@ if (typeof Slick === "undefined") {
$canvas.width(canvasWidth);
$headerRow.width(canvasWidth);
$headers.width(getHeadersWidth());
viewportHasHScroll = (canvasWidth > viewportW - scrollbarDimensions.width);
viewportHasHScroll = (canvasWidth >= viewportW - scrollbarDimensions.width);
}

$headerRowSpacer.width(canvasWidth + (viewportHasVScroll ? scrollbarDimensions.width : 0));
Expand Down Expand Up @@ -1986,7 +1987,7 @@ if (typeof Slick === "undefined") {
$headerRowScroller[0].scrollLeft = scrollLeft;
}

if (vScrollDist) {
if(vScrollDist && (vScrollDist > options.rowHeight)) {
vScrollDir = prevScrollTop < scrollTop ? 1 : -1;
prevScrollTop = scrollTop;

Expand Down