Please add the distance delay to the standard code. #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a small distance delay on the sortable to prevent users from unintended triggering of the reordering. (Happens all the time i'm using slickgrid). i.e. the users tries to sort the column but fails since his mouse was still on the move a little bit and 1px is enough to trigger reordeing here. Please try, it still feels very responsive.
| @@ -656,6 +656,7 @@ if (typeof Slick === "undefined") { | |||
| $headers.filter(":ui-sortable").sortable("destroy"); | |||
| $headers.sortable({ | |||
| containment: "parent", | |||
| distance: 5, | |||
There was a problem hiding this comment.
That will also do it. Changed it in the pull request.
Am 18.01.2013 21:20, schrieb Michael Leibman:
In slick.grid.js:
@@ -656,6 +656,7 @@ if (typeof Slick === "undefined") {
$headers.filter(":ui-sortable").sortable("destroy");
$headers.sortable({
containment: "parent",
distance: 5,Could you change this to 3px?
—
Reply to this email directly or view it on GitHub
https://github.com/mleibman/SlickGrid/pull/517/files#r2701389.
| @@ -656,6 +656,7 @@ if (typeof Slick === "undefined") { | |||
| $headers.filter(":ui-sortable").sortable("destroy"); | |||
| $headers.sortable({ | |||
| containment: "parent", | |||
| distance: 3, | |||
There was a problem hiding this comment.
Changed the distance value to 3
mleibman
added a commit
that referenced
this pull request
Jan 18, 2013
Add the distance delay to the header drag code.
dholcombe
added a commit
to dholcombe/SlickGrid
that referenced
this pull request
Aug 12, 2013
Equivalent to Merge pull request mleibman#517 from ckosmowski/master on Jan 18, 2013 in the mleibman master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a small distance delay on the sortable to prevent users from unintended
triggering of the reordering. (Happens all the time i'm using slickgrid).
i.e. the users tries to sort the column but fails since his mouse was still
on the move a little bit and 1px is enough to trigger reordeing here.
Please try, it still feels very responsive.