Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.0] Rewrite ExpandedPostView #1000

Open
Sjmarf opened this issue Apr 4, 2024 · 0 comments
Open

[2.0] Rewrite ExpandedPostView #1000

Sjmarf opened this issue Apr 4, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@Sjmarf
Copy link
Contributor

Sjmarf commented Apr 4, 2024

I think we should fully rewrite the comment system. In my opinion, we should:

  • Improve the collapse animation to make it less jarring when collapsing a large comment stack. This might be made easier by defining the comment views recursively, such that each comment view renders all of its children.
  • Add a "show more replies" button akin to what lemmy-ui has for very large posts where not all comments are initially loaded. Currently, we don't attempt to load the additional comments at all (Child comments in some posts don't load #844). The button should either add the extra comments to the view, or push a new view onto the navigation stack that displays the new comments. The first option is more convenient, but the second may be necessary if the comment depth gets so great that we can't fit the comments on the screen anymore. Potentially, we could support both options and choose which to use based or the number of replies and/or the depth of those replies.
  • Fix our "Hot" sorting and add support for "Controversial" ("hot" comment sort mode consistency with Lemmy #804)
@Sjmarf Sjmarf added the enhancement New feature or request label Apr 4, 2024
@Sjmarf Sjmarf self-assigned this Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: To Triage
Development

No branches or pull requests

1 participant