Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic profile #1079

Merged
merged 32 commits into from
Jun 5, 2024
Merged

Basic profile #1079

merged 32 commits into from
Jun 5, 2024

Conversation

Sjmarf
Copy link
Contributor

@Sjmarf Sjmarf commented Jun 2, 2024

Re-implemented part of the profile page. Most of this is copy/paste from v1. User content and flairs aren't displayed yet, and there aren't yet any actions in the ellipsis menu.

@Sjmarf Sjmarf requested a review from a team as a code owner June 2, 2024 11:38
@Sjmarf Sjmarf requested review from WestonHanners and ShadowJonathan and removed request for a team June 2, 2024 11:38
Copy link
Member

@EricBAndrews EricBAndrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good--bunch of palette conformance comments and a couple nits.

Can't build locally--MarkdownText in PersonView:65 throws an error

Mlem/App/Utility/Extensions/Date+Formatter.swift Outdated Show resolved Hide resolved
Mlem/App/Utility/Extensions/Int+abbreviated.swift Outdated Show resolved Hide resolved
Mlem/App/Views/Pages/PersonView.swift Outdated Show resolved Hide resolved
Mlem/App/Views/Pages/PersonView.swift Outdated Show resolved Hide resolved
Mlem/App/Views/Root/Tabs/Profile/Profile View.swift Outdated Show resolved Hide resolved
Mlem/App/Views/Shared/BubblePicker/BubblePicker.swift Outdated Show resolved Hide resolved
Mlem/App/Views/Shared/BubblePicker/BubblePicker.swift Outdated Show resolved Hide resolved
Mlem/App/Views/Shared/MarkdownImageView.swift Outdated Show resolved Hide resolved
Mlem/App/Views/Shared/ProfileDateView.swift Outdated Show resolved Hide resolved
Mlem/App/Views/Pages/PersonView.swift Show resolved Hide resolved
@Sjmarf
Copy link
Contributor Author

Sjmarf commented Jun 2, 2024

Can't build locally--MarkdownText in PersonView:65 throws an error

I added MarkdownText to LemmyMarkdownUI yesterday. Maybe that package needs to be properly versioned for it to update automatically 🤔 Right-clicking on LemmyMarkdownUI in the sidebar shows an option to update manually

@EricBAndrews
Copy link
Member

Can't build locally--MarkdownText in PersonView:65 throws an error

I added MarkdownText to LemmyMarkdownUI yesterday. Maybe that package needs to be properly versioned for it to update automatically 🤔 Right-clicking on LemmyMarkdownUI in the sidebar shows an option to update manually

Hmm, yeah, that did it. Weirdly it didn't work if I did Reset package caches, which also forces a fetch 🤔 🤔 🤔

Sjmarf and others added 3 commits June 2, 2024 17:35
Co-authored-by: Eric Andrews <eric.b.andrews.auto@protonmail.com>
@Sjmarf Sjmarf requested a review from EricBAndrews June 2, 2024 16:44
Copy link
Member

@EricBAndrews EricBAndrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@Sjmarf Sjmarf merged commit 6cf19de into dev2 Jun 5, 2024
1 check passed
@Sjmarf Sjmarf deleted the sjmarf/profile branch June 5, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants