-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic profile #1079
Basic profile #1079
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good--bunch of palette
conformance comments and a couple nits.
Can't build locally--MarkdownText
in PersonView:65
throws an error
I added |
Hmm, yeah, that did it. Weirdly it didn't work if I did |
…to sjmarf/profile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🔥
Re-implemented part of the profile page. Most of this is copy/paste from v1. User content and flairs aren't displayed yet, and there aren't yet any actions in the ellipsis menu.