Show transition on account switch #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sjmarf
requested review from
WestonHanners and
ShadowJonathan
and removed request for
a team
EricBAndrews
requested changes
Jun 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1065
The toggle for this is under the account list in settings. It's set to reload the feed by default. In the account switcher, you can swipe or long press to access the non-default behaviour.
I also fixed the quick switcher always showing a
.largesheet, not the.mediumsheet it's supposed to - this seems to be caused by theProgressView, so I've disabled it for now.Also made some tweaks the toast system to (hopefully) stop toasts from occasionally getting stuck and not going away.