Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab navigation behaviour #911

Merged
merged 3 commits into from
Feb 10, 2024
Merged

Tab navigation behaviour #911

merged 3 commits into from
Feb 10, 2024

Conversation

boscojwho
Copy link
Contributor

Pull Request Information

About this Pull Request

Adds a property in Navigation that allows users to eventually specify what tab bar navigation behaviour to use.

  • This PR does not contain any UI/UX changes.

@boscojwho boscojwho requested a review from a team as a code owner February 6, 2024 00:01
@boscojwho boscojwho requested review from mormaer and ShadowJonathan and removed request for a team February 6, 2024 00:01
Copy link
Member

@EricBAndrews EricBAndrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Since this doesn't alter UI/UX, let's hold off on merging it until we get 1.2 out the door

@boscojwho boscojwho merged commit 41a3f51 into dev Feb 10, 2024
4 checks passed
@boscojwho boscojwho deleted the bosco/tab-navigation-behaviour branch February 10, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants