Add support for Python 3.11 #199
Open
+8
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead, accept any arguments ``random.shuffle`` accepts. Prior to Python 3.11 this was `random` but Python 3.9 deprecated this feature and Python 3.11 removed it. python/cpython#84645 Accepting `*args, **kwargs` makes the signature compatible with whatever Python runtime happens to be in use.
There is no guarantee that the given key and the key in the dictionary will be identical. There is only a guarantee that they will compare equal to each other. Something has changed on CPython 3.11 so that even the very simple case of a short string key the underlying objects are not necessarily identical anymore (though in previous CPython versions they typically would be).
|
Thanks for this patch. I can confirm this fixes #198. |
mlenzen
approved these changes
Mar 12, 2023
|
Are there blockers for merging this @mlenzen ? (I can't see why the CI jobs failed - GA expired the logs - and I can't re-run the action without pushing more revisions) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #198