Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ready for production #30

Merged
merged 38 commits into from
May 20, 2019
Merged

Ready for production #30

merged 38 commits into from
May 20, 2019

Conversation

mlevit
Copy link
Owner

@mlevit mlevit commented May 17, 2019

No description provided.

@mlevit mlevit requested a review from jihygk May 17, 2019 10:00
@mlevit mlevit added the enhancement New feature or request label May 17, 2019
@mlevit
Copy link
Owner Author

mlevit commented May 17, 2019

@jihygk can you review the new KMS pytest added. Need to implement as many tests as possible but need to understand your setup a bit more.

jihygk
jihygk suggested changes May 20, 2019
View reviewed changes
Copy link
Contributor

@jihygk jihygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests look good except Static helper methods being duplicated, and the magic number for cmk backing key rotation test?

auto_remediate/test/test_securityhub_kms.py Outdated Show resolved Hide resolved
auto_remediate/test/test_securityhub_s3.py Show resolved Hide resolved
@mlevit mlevit mentioned this pull request May 20, 2019
Open
@mlevit mlevit merged commit f7e351c into master May 20, 2019
@mlevit mlevit deleted the small-tweaks branch May 20, 2019 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jihygk jihygk jihygk requested changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mlevit @jihygk