Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend max digest size to support SHA-1 #10388

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

bhack
Copy link

@bhack bhack commented Nov 14, 2023

🛠 DevTools 🛠

Open in GitHub Codespaces

Install mlflow from this PR

pip install git+https://github.com/mlflow/mlflow.git@refs/pull/10388/merge

Checkout with GitHub CLI

gh pr checkout 10388

Signed-off-by: bhack bhack@users.noreply.github.com

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

Does this PR require documentation update?

  • [x ] No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Release Notes

Is this a user-facing change?

  • [] No. You can skip the rest of this section.
  • [] Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/artifacts: Artifact stores and artifact logging
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages
  • area/examples: Example code
  • area/gateway: AI Gateway service, Gateway client APIs, third-party Gateway integrations
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/recipes: Recipes, Recipe APIs, Recipe configs, Recipe Templates
  • area/projects: MLproject format, project running backends
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/server-infra: MLflow Tracking server backend
  • [] area/tracking: Tracking Service, tracking client APIs, autologging

Interface

  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Models
  • area/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registry
  • area/windows: Windows support

Language

  • language/r: R APIs and clients
  • language/java: Java APIs and clients
  • language/new: Proposals for new client languages

Integrations

  • integrations/azure: Azure and Azure ML integrations
  • integrations/sagemaker: SageMaker integrations
  • integrations/databricks: Databricks integrations

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • [x ] rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Signed-off-by: bhack <bhack@users.noreply.github.com>
Copy link

github-actions bot commented Nov 14, 2023

Documentation preview for 4158242 will be available here when this CircleCI job completes successfully.

More info

@github-actions github-actions bot added area/sqlalchemy Use of SQL alchemy in tracking service or model registry rn/feature Mention under Features in Changelogs. labels Nov 14, 2023
Signed-off-by: bhack <bhack@users.noreply.github.com>
@BenWilson2
Copy link
Member

Hi @bhack I believe you'll need to craft a database schema migration script for this via alembic.

Signed-off-by: bhack <bhack@users.noreply.github.com>
…a1_digest

Signed-off-by: bhack <bhack@users.noreply.github.com>
@bhack
Copy link
Author

bhack commented Nov 15, 2023

I have generated one but it seems almost empty. Do I need to run the script on a specific commit?

Signed-off-by: bhack <bhack@users.noreply.github.com>
Signed-off-by: bhack <bhack@users.noreply.github.com>
Signed-off-by: bhack <bhack@users.noreply.github.com>
@bhack
Copy link
Author

bhack commented Nov 15, 2023

Ok it is not automated so I've implemented the update manually.

@bhack
Copy link
Author

bhack commented Nov 21, 2023

@BenWilson2 what else?

@bhack
Copy link
Author

bhack commented Mar 5, 2024

Gently ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/sqlalchemy Use of SQL alchemy in tracking service or model registry rn/feature Mention under Features in Changelogs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants