Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keras 3.0 Logging With MLflow #10415

Merged
merged 42 commits into from Dec 3, 2023

Conversation

jessechancy
Copy link
Collaborator

@jessechancy jessechancy commented Nov 15, 2023

馃洜 DevTools 馃洜

Open in GitHub Codespaces

Install mlflow from this PR

pip install git+https://github.com/mlflow/mlflow.git@refs/pull/10415/merge

Checkout with GitHub CLI

gh pr checkout 10415

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/artifacts: Artifact stores and artifact logging
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages
  • area/examples: Example code
  • area/gateway: AI Gateway service, Gateway client APIs, third-party Gateway integrations
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/recipes: Recipes, Recipe APIs, Recipe configs, Recipe Templates
  • area/projects: MLproject format, project running backends
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/server-infra: MLflow Tracking server backend
  • area/tracking: Tracking Service, tracking client APIs, autologging

Interface

  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Models
  • area/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registry
  • area/windows: Windows support

Language

  • language/r: R APIs and clients
  • language/java: Java APIs and clients
  • language/new: Proposals for new client languages

Integrations

  • integrations/azure: Azure and Azure ML integrations
  • integrations/sagemaker: SageMaker integrations
  • integrations/databricks: Databricks integrations

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Copy link

github-actions bot commented Nov 15, 2023

Documentation preview for 3a4e6ef will be available here when this CircleCI job completes successfully.

More info

@github-actions github-actions bot added the rn/none List under Small Changes in Changelogs. label Nov 15, 2023
@@ -0,0 +1,8 @@
Getting Started with MLflow + Keras 3.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a landing page for this that is similar to the one created for transformers in this PR? #10360

Copy link
Collaborator

@chenmoneygithub chenmoneygithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jesse, well written!

Some minor comments. For the images, could you try uploading the images to imgur.com and link it here? It's not a perfect solution but should work for us now.

Copy link
Collaborator

@chenmoneygithub chenmoneygithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Let's fix the build-doc CI, the error msg is:

/home/circleci/project/docs/source/deep-learning/keras/quickstart/quickstart_keras_core.ipynb:15: WARNING: Content block expected for the "raw" directive; none found.
/home/circleci/project/docs/source/deep-learning/keras/quickstart/quickstart_keras_core.ipynb:15: WARNING: Content block expected for the "raw" directive; none found.
/home/circleci/project/docs/source/deep-learning/keras/quickstart/quickstart_keras_core.ipynb:15: WARNING: Content block expected for the "raw" directive; none found.
/home/circleci/project/docs/source/deep-learning/keras/quickstart/quickstart_keras_core.ipynb:951: WARNING: Title level inconsistent:

},
"source": [
"# Get Started with Keras 3.0 + MLflow\n",
"**Author:** Jesse Chan<br>\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our current doc does not show the author name, we can delete the author/date block.

}
],
"source": [
"!pip install -q keras-core mlflow jax jaxlib torch tensorflow"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason our sphinx lint complains about this line. Let's inline this with text block to bypass the warning in doc-build.

@jessechancy jessechancy enabled auto-merge (squash) December 1, 2023 18:17

.. raw:: html

<a href="quickstart/quickstart_tensorflow.html" class="download-btn">View the Quickstart</a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<a href="quickstart/quickstart_tensorflow.html" class="download-btn">View the Quickstart</a>
<a href="quickstart/quickstart_keras_core.html" class="download-btn">View the Quickstart</a>

@jessechancy jessechancy enabled auto-merge (squash) December 2, 2023 00:55
Signed-off-by: Jesse Chan <jesse.chan@databricks.com>
Signed-off-by: Jesse Chan <jesse.chan@databricks.com>
Signed-off-by: Jesse Chan <jesse.chan@databricks.com>
Signed-off-by: Jesse Chan <jesse.chan@databricks.com>
Signed-off-by: Jesse Chan <jesse.chan@databricks.com>
Signed-off-by: Jesse Chan <jesse.chan@databricks.com>
Signed-off-by: Jesse Chan <jesse.chan@databricks.com>
Signed-off-by: Jesse Chan <jesse.chan@databricks.com>
Signed-off-by: Jesse Chan <jesse.chan@databricks.com>
Signed-off-by: Jesse Chan <jesse.chan@databricks.com>
Signed-off-by: Jesse Chan <jesse.chan@databricks.com>
Signed-off-by: Jesse Chan <jesse.chan@databricks.com>
Signed-off-by: Jesse Chan <jesse.chan@databricks.com>
Signed-off-by: Jesse Chan <jesse.chan@databricks.com>
Signed-off-by: Jesse Chan <jesse.chan@databricks.com>
Signed-off-by: Jesse Chan <jesse.chan@databricks.com>
Signed-off-by: Jesse Chan <jesse.chan@databricks.com>
Signed-off-by: Jesse Chan <jesse.chan@databricks.com>
Signed-off-by: Jesse Chan <jesse.chan@databricks.com>
Signed-off-by: Jesse Chan <jesse.chan@databricks.com>
Signed-off-by: Jesse Chan <jesse.chan@databricks.com>
Signed-off-by: Jesse Chan <jesse.chan@databricks.com>
Signed-off-by: Jesse Chan <jesse.chan@databricks.com>
Signed-off-by: Jesse Chan <jesse.chan@databricks.com>
Signed-off-by: Jesse Chan <jesse.chan@databricks.com>
Signed-off-by: Jesse Chan <jesse.chan@databricks.com>
Signed-off-by: Jesse Chan <jesse.chan@databricks.com>
Signed-off-by: Jesse Chan <jesse.chan@databricks.com>
Signed-off-by: Jesse Chan <jesse.chan@databricks.com>
Signed-off-by: Jesse Chan <jesse.chan@databricks.com>
Signed-off-by: Jesse Chan <jesse.chan@databricks.com>
Signed-off-by: Jesse Chan <jesse.chan@databricks.com>
Signed-off-by: Jesse Chan <jesse.chan@databricks.com>
Signed-off-by: Jesse Chan <jesse.chan@databricks.com>
Signed-off-by: Jesse Chan <jesse.chan@databricks.com>
Signed-off-by: Jesse Chan <jesse.chan@databricks.com>
Signed-off-by: Jesse Chan <jesse.chan@databricks.com>
Signed-off-by: Jesse Chan <jesse.chan@databricks.com>
Signed-off-by: Jesse Chan <jesse.chan@databricks.com>
Signed-off-by: Jesse Chan <jesse.chan@databricks.com>
Signed-off-by: Jesse Chan <jesse.chan@databricks.com>
Signed-off-by: Jesse Chan <jesse.chan@databricks.com>
@jessechancy jessechancy merged commit d10f342 into mlflow:master Dec 3, 2023
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn/none List under Small Changes in Changelogs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants