Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1] Copy gateway server CLI to mlflow deployments start-server #10426

Merged
merged 13 commits into from Nov 21, 2023

Conversation

dbczumar
Copy link
Collaborator

@dbczumar dbczumar commented Nov 16, 2023

馃洜 DevTools 馃洜

Open in GitHub Codespaces

Install mlflow from this PR

pip install git+https://github.com/mlflow/mlflow.git@refs/pull/10426/merge

Checkout with GitHub CLI

gh pr checkout 10426

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

Move gateway server CLI to mlflow deployments start-server

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/artifacts: Artifact stores and artifact logging
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages
  • area/examples: Example code
  • area/gateway: AI Gateway service, Gateway client APIs, third-party Gateway integrations
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/recipes: Recipes, Recipe APIs, Recipe configs, Recipe Templates
  • area/projects: MLproject format, project running backends
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/server-infra: MLflow Tracking server backend
  • area/tracking: Tracking Service, tracking client APIs, autologging

Interface

  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Models
  • area/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registry
  • area/windows: Windows support

Language

  • language/r: R APIs and clients
  • language/java: Java APIs and clients
  • language/new: Proposals for new client languages

Integrations

  • integrations/azure: Azure and Azure ML integrations
  • integrations/sagemaker: SageMaker integrations
  • integrations/databricks: Databricks integrations

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Signed-off-by: dbczumar <corey.zumar@databricks.com>
Copy link

github-actions bot commented Nov 16, 2023

Documentation preview for fbb4495 will be available here when this CircleCI job completes successfully.

More info

@github-actions github-actions bot added area/deployments MLflow Deployments client APIs, server, and third-party Deployments integrations rn/none List under Small Changes in Changelogs. labels Nov 16, 2023
catch_exceptions=False,
)
assert res.exit_code == 2
assert "The gateway configuration is invalid" in res.output
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renaming of error messages, etc. will be done in follow-up PRs

@dbczumar
Copy link
Collaborator Author

@mlflow-automation autoformat

Signed-off-by: mlflow-automation <mlflow-automation@users.noreply.github.com>
@dbczumar dbczumar changed the title Move gateway server CLI to mlflow deployments start-server [WIP] Move gateway server CLI to mlflow deployments start-server Nov 16, 2023
Signed-off-by: dbczumar <corey.zumar@databricks.com>
@dbczumar dbczumar changed the title [WIP] Move gateway server CLI to mlflow deployments start-server [WIP][1] Copy gateway server CLI to mlflow deployments start-server Nov 20, 2023
Signed-off-by: dbczumar <corey.zumar@databricks.com>
Copy link
Member

@harupy harupy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: dbczumar <corey.zumar@databricks.com>
Signed-off-by: dbczumar <corey.zumar@databricks.com>
Signed-off-by: dbczumar <corey.zumar@databricks.com>
@@ -33,4 +33,4 @@ jobs:
pytest pytest-timeout pytest-asyncio httpx psutil
- name: Run tests
run: |
pytest tests/deploymnets/databricks
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

Signed-off-by: dbczumar <corey.zumar@databricks.com>
Signed-off-by: dbczumar <corey.zumar@databricks.com>
Co-authored-by: Harutaka Kawamura <hkawamura0130@gmail.com>
Signed-off-by: Corey Zumar <39497902+dbczumar@users.noreply.github.com>
Signed-off-by: Corey Zumar <39497902+dbczumar@users.noreply.github.com>
Signed-off-by: dbczumar <corey.zumar@databricks.com>
Signed-off-by: dbczumar <corey.zumar@databricks.com>
Copy link
Member

@harupy harupy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dbczumar dbczumar changed the title [WIP][1] Copy gateway server CLI to mlflow deployments start-server [1] Copy gateway server CLI to mlflow deployments start-server Nov 21, 2023
@dbczumar dbczumar merged commit 9f1d547 into mlflow:gateway-migration Nov 21, 2023
35 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/deployments MLflow Deployments client APIs, server, and third-party Deployments integrations gateway-migration rn/none List under Small Changes in Changelogs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants