Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Update documentation to fix KeyError in demo code in quickstart #10540

Merged
merged 1 commit into from Dec 1, 2023

Conversation

wllgrnt
Copy link
Contributor

@wllgrnt wllgrnt commented Nov 29, 2023

🛠 DevTools 🛠

Open in GitHub Codespaces

Install mlflow from this PR

pip install git+https://github.com/mlflow/mlflow.git@refs/pull/10540/merge

Checkout with GitHub CLI

gh pr checkout 10540

Related Issues/PRs

Resolve #10539

What changes are proposed in this pull request?

Updates the documentation so that the demo code here doesn't throw a KeyError when run.

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

image

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

This one-liner change updates the hyperopt usage example code in the quickstart documentaion so that the correct variable is referenced when logging the best tensorflow model.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/artifacts: Artifact stores and artifact logging
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages
  • area/examples: Example code
  • area/gateway: AI Gateway service, Gateway client APIs, third-party Gateway integrations
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/recipes: Recipes, Recipe APIs, Recipe configs, Recipe Templates
  • area/projects: MLproject format, project running backends
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/server-infra: MLflow Tracking server backend
  • area/tracking: Tracking Service, tracking client APIs, autologging

Interface

  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Models
  • area/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registry
  • area/windows: Windows support

Language

  • language/r: R APIs and clients
  • language/java: Java APIs and clients
  • language/new: Proposals for new client languages

Integrations

  • integrations/azure: Azure and Azure ML integrations
  • integrations/sagemaker: SageMaker integrations
  • integrations/databricks: Databricks integrations

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Copy link

@wllgrnt Thank you for the contribution! Could you fix the following issue(s)?

⚠ DCO check

The DCO check failed. Please sign off your commit(s) by following the instructions here. See https://github.com/mlflow/mlflow/blob/master/CONTRIBUTING.md#sign-your-work for more details.

Copy link

github-actions bot commented Nov 29, 2023

Documentation preview for c3502f3 will be available here when this CircleCI job completes successfully.

More info

@github-actions github-actions bot added area/docs Documentation issues rn/none List under Small Changes in Changelogs. labels Nov 29, 2023
@wllgrnt wllgrnt force-pushed the will-fix-quickstart-doc-keyerror branch 2 times, most recently from ada6790 to b89fb8d Compare November 29, 2023 23:40
Copy link
Collaborator

@B-Step62 B-Step62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wllgrnt LGTM! Thank you so much for catching this issue and proactively making the fix! Will merge once all CI tests passed.

@B-Step62 B-Step62 enabled auto-merge (squash) November 30, 2023 08:37
@B-Step62 B-Step62 closed this Nov 30, 2023
auto-merge was automatically disabled November 30, 2023 08:42

Pull request was closed

@B-Step62 B-Step62 reopened this Nov 30, 2023
@B-Step62
Copy link
Collaborator

B-Step62 commented Nov 30, 2023

fyi: it seems some jobs were stuck, closed and re-opend to trigger them

@B-Step62
Copy link
Collaborator

@wllgrnt Very weird but some jobs are still not executing. Could you run followings to force triggering them again? While it seems to be an intermittent issue in Github, I can investigate if that happens again. Thanks!

$ git commit -sm --amend --no-edit   
$ git push origin HEAD -f

Signed-off-by: William Grant <william.grant@aprioriinvestments.com>
@wllgrnt wllgrnt force-pushed the will-fix-quickstart-doc-keyerror branch from b89fb8d to c3502f3 Compare November 30, 2023 16:55
Copy link
Collaborator

@chenmoneygithub chenmoneygithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@wllgrnt
Copy link
Contributor Author

wllgrnt commented Nov 30, 2023

@wllgrnt Very weird but some jobs are still not executing. Could you run followings to force triggering them again? While it seems to be an intermittent issue in Github, I can investigate if that happens again. Thanks!

$ git commit -sm --amend --no-edit   
$ git push origin HEAD -f

The force-push above doesn't seem to have triggered the jobs, let me know if there's something else I should try

@BenWilson2 BenWilson2 merged commit 36cee8c into mlflow:master Dec 1, 2023
16 checks passed
@B-Step62
Copy link
Collaborator

B-Step62 commented Dec 1, 2023

@wllgrnt Thanks for trying it out, that's very weird it didn't work. It seems the same issue happens for some other PRs so I will investigate further. Meanwhile, we overrode the checks and pushed as there shouldn't be a big concern for this PR. Thank you so much for your contribution!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Documentation issues rn/none List under Small Changes in Changelogs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC-FIX] Code for the 'Comparing Runs' quickstart throws KeyError
4 participants