Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Clarifai as a provider in MLflow Deployments Server #10642

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Add Clarifai as a provider in MLflow Deployments Server #10642

wants to merge 11 commits into from

Conversation

sainivedh
Copy link

Related Issues/PRs

Add Clarifai as a provider in MLflow Deployments Server

What changes are proposed in this pull request?

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/artifacts: Artifact stores and artifact logging
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages
  • area/examples: Example code
  • area/gateway: AI Gateway service, Gateway client APIs, third-party Gateway integrations
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/recipes: Recipes, Recipe APIs, Recipe configs, Recipe Templates
  • area/projects: MLproject format, project running backends
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/server-infra: MLflow Tracking server backend
  • area/tracking: Tracking Service, tracking client APIs, autologging

Interface

  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Models
  • area/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registry
  • area/windows: Windows support

Language

  • language/r: R APIs and clients
  • language/java: Java APIs and clients
  • language/new: Proposals for new client languages

Integrations

  • integrations/azure: Azure and Azure ML integrations
  • integrations/sagemaker: SageMaker integrations
  • integrations/databricks: Databricks integrations

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

@sainivedh
add clarifai as provider
74c0df9 
Signed-off-by: Sai Nivedh <sainivedh123@gmail.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023 •
edited

Documentation preview for e9791ab will be available here when this CircleCI job completes successfully.

More info

@sainivedh
add test_embeddings_batch
98829d1 
Signed-off-by: Sai Nivedh <sainivedh123@gmail.com>
@sainivedh sainivedh mentioned this pull request Dec 7, 2023
Closed
37 tasks
@sainivedh sainivedh marked this pull request as ready for review December 7, 2023 16:19
@sainivedh
Copy link
Author

@BenWilson2 Could you please review when you have a moment?

@BenWilson2
Copy link
Member

Hi @sainivedh the gateway has been deprecated. Could you add the implementation here instead of the deprecated namespace?

@sainivedh
Copy link
Author

@BenWilson2, I have opened this pull request to update to the latest version of the Deployment Server. I've included examples here.

mlflow deployments start-server --config-path examples/deployments/deployments_server/clarifai/config.yaml  --port 7000

@BenWilson2
Copy link
Member

@BenWilson2, I have opened this pull request to update to the latest version of the Deployment Server. I've included examples here.

mlflow deployments start-server --config-path examples/deployments/deployments_server/clarifai/config.yaml  --port 7000

You added implementations to mlflow.gateway. This namespace is deprecated. See the link that I provided for where the server implementation would need to be moved to.

@sainivedh
Copy link
Author

@BenWilson2, I appreciate your suggestions, but I'm a bit uncertain about your point. The deployments server utilizes get_provider from mlflow.gateway.providers, which includes all other providers. If I overlooked something, could you please clarify?

@BenWilson2
Copy link
Member

@BenWilson2, I appreciate your suggestions, but I'm a bit uncertain about your point. The deployments server utilizes get_provider from mlflow.gateway.providers, which includes all other providers. If I overlooked something, could you please clarify?

LOL sorry, it's been a long week. I'll take a look at the PR now ;)

BenWilson2
BenWilson2 reviewed Dec 12, 2023
View reviewed changes
examples/deployments/deployments_server/clarifai/example.py
# Embeddings request
response_embeddings = client.predict(
endpoint="embeddings",
inputs={"input": ["Do you carry the Storm Trooper costume in size 2T?"]},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha great example

@BenWilson2
Copy link
Member

Hi @sainivedh when you push the changes, can you rebase on master as well just to make sure that you have the latest CI config?

sainivedh and others added 9 commits December 13, 2023 00:18
@sainivedh @BenWilson2
Update examples/deployments/deployments_server/clarifai/README.md
1a9d483 
Co-authored-by: Ben Wilson <39283302+BenWilson2@users.noreply.github.com>
Signed-off-by: Sai Nivedh <sainivedh123@gmail.com>
@sainivedh @BenWilson2
Update mlflow/gateway/providers/clarifai.py
5b7e1d3 
Co-authored-by: Ben Wilson <39283302+BenWilson2@users.noreply.github.com>
Signed-off-by: Sai Nivedh <sainivedh123@gmail.com>
@sainivedh @BenWilson2
Update mlflow/gateway/providers/clarifai.py
89db116 
Co-authored-by: Ben Wilson <39283302+BenWilson2@users.noreply.github.com>
Signed-off-by: Sai Nivedh <sainivedh123@gmail.com>
@sainivedh @BenWilson2
Update mlflow/gateway/providers/clarifai.py
0b359e6 
Co-authored-by: Ben Wilson <39283302+BenWilson2@users.noreply.github.com>
Signed-off-by: Sai Nivedh <sainivedh123@gmail.com>
@sainivedh @BenWilson2
Update mlflow/gateway/providers/clarifai.py
4e78bf2 
Co-authored-by: Ben Wilson <39283302+BenWilson2@users.noreply.github.com>
Signed-off-by: Sai Nivedh <sainivedh123@gmail.com>
@sainivedh
add test_chat_is_not_supported_for_clarifai
8ac19a7 
Signed-off-by: Sai Nivedh <sainivedh123@gmail.com>
@sainivedh
change CLARIFAI_PAT to snake case
d540d6a 
Signed-off-by: Sai Nivedh <sainivedh123@gmail.com>
@sainivedh
update providers order
cc1900e 
Signed-off-by: Sai Nivedh <sainivedh123@gmail.com>
@sainivedh
Merge branch 'master' into clarifai-integration
e9791ab 
Signed-off-by: Sai Nivedh <sainivedh123@gmail.com>
@sainivedh
Copy link
Author

Hello @BenWilson2, I've pushed the changes. Kindly take a look when you get a chance.

@sainivedh
Copy link
Author

Hello @BenWilson2, Could you please review when you have a moment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenWilson2 BenWilson2 Awaiting requested review from BenWilson2

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sainivedh @BenWilson2